Changeset 62963

Timestamp:

08/01/2026 12:29:43 PM (5 weeks ago)

Author:

wildworks

Message:

Media: Fix a jQuery Migrate warning for disabled buttons.

Under jQuery 4.0, disabling a media button or the image cropper's action button triggered a jQuery Migrate warning about the boolean disabled attribute. These buttons now toggle the disabled property instead, which removes the warning and keeps the behavior unchanged.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/10661

Props audrasjb, azaozz, hbhalodia, neo2k23, wildworks.
See #64425.

Location:

trunk/src/js/media

Files:

• controllers/cropper.js (modified) (1 diff)
• views/button.js (modified) (1 diff)

trunk/src/js/media/controllers/cropper.js

@@ -117 +117 @@
 
                                                 this.$el.text(l10n.cropping);
-                                                this.$el.attr('disabled', true);
+                                                this.$el.prop( 'disabled', true );
 
                                                 controller.state().doCrop( selection ).done( function( croppedImage ) {

trunk/src/js/media/views/button.js

@@ -65 +65 @@
                 this.el.className = classes.join(' ');
 
-                this.$el.attr( 'disabled', model.disabled );
+                this.$el.prop( 'disabled', model.disabled );
                 this.$el.text( this.model.get('text') );