Changeset 62964

Timestamp:

08/01/2026 04:42:13 PM (6 weeks ago)

Author:

SergeyBiryukov

Message:

HTML API: Use str_contains() instead of strpos() in WP_HTML_Tag_Processor.

The str_contains() function was introduced in PHP 8.0 and a polyfill is available in WordPress Core, making the intent of the check clearer than comparing the result of strpos() against false.

Follow-up to [62687].

Props Soean, mukesh27, westonruter.
See #64897.

File:

• trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -2074 +2074 @@
                                 $is_valid_pi = (
                                         0 !== $target_length &&
-                                        false !== strpos( " \t\f\r\n?>", $html[ $target_at + $target_length ] ) &&
+                                        str_contains( " \t\f\r\n?>", $html[ $target_at + $target_length ] ) &&
                                         ! ( 3 === $target_length && 0 === substr_compare( $html, 'xml', $target_at, 3, true ) ) &&
                                         ! ( 14 === $target_length && 0 === substr_compare( $html, 'xml-stylesheet', $target_at, 14, true ) )