Changeset 63158

Timestamp:

08/07/2026 07:12:29 PM (5 weeks ago)

Author:

dmsnell

Message:

Docs: Revert "Indicate absint() returns non-negative-int...".

The introduction of a return-type annotation for absint() created fatal errors in cases where the function returns a float value. This resulted when the value passed into the function is smaller than PHP_INT_MIN. Since PHP’s int type is unable to represent the magnitude of that number in the positive, it returns a float value instead.

Reverting the type annotation prevents the crashing, but additional follow-up is warranted to ensure that the function produces the expected return types.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/12940
Discussed in: https://core.trac.wordpress.org/ticket/65826

Follow-up to [62647].

Props dmsnell, josephscott, westonruter.
Fixes #65826. See #64898.

Location:

trunk

Files:

• src/wp-includes/load.php (modified) (1 diff)
• tests/phpstan/baselines/argument.type.neon (modified) (5 diffs)
• tests/phpstan/baselines/notIdentical.alwaysTrue.neon (modified) (1 diff)

trunk/src/wp-includes/load.php

@@ -1465 +1465 @@
  * @param mixed $maybeint Data you wish to have converted to a non-negative integer.
  * @return int A non-negative integer.
- * @phpstan-return non-negative-int
- */
-function absint( $maybeint ): int {
+ */
+function absint( $maybeint ) {
         return abs( (int) $maybeint );
 }

trunk/tests/phpstan/baselines/argument.type.neon

@@ -57 +57 @@
                         message: '#^Parameter \#1 \$text of function esc_attr expects string, int given\.$#'
                         identifier: argument.type
-                        count: 3
-                        path: ../../../src/wp-admin/edit-comments.php
-                -
-                        message: '#^Parameter \#1 \$text of function esc_attr expects string, int\<0, max\> given\.$#'
-                        identifier: argument.type
-                        count: 1
+                        count: 4
                         path: ../../../src/wp-admin/edit-comments.php
                 -
@@ -575 +570 @@
                         path: ../../../src/wp-admin/nav-menus.php
                 -
-                        message: '#^Parameter \#2 \$menu_data of function wp_save_nav_menu_items expects array\<array\>, int\<0, max\> given\.$#'
+                        message: '#^Parameter \#2 \$menu_data of function wp_save_nav_menu_items expects array\<array\>, int given\.$#'
                         identifier: argument.type
                         count: 1
@@ -715 +710 @@
                         path: ../../../src/wp-content/themes/twentyeleven/inc/theme-options.php
                 -
-                        message: '#^Parameter \#1 \$text of function esc_attr expects string, int\<0, max\> given\.$#'
+                        message: '#^Parameter \#1 \$text of function esc_attr expects string, int given\.$#'
                         identifier: argument.type
                         count: 1
@@ -780 +775 @@
                         path: ../../../src/wp-content/themes/twentyfourteen/inc/widgets.php
                 -
-                        message: '#^Parameter \#1 \$text of function esc_attr expects string, int\<0, max\> given\.$#'
+                        message: '#^Parameter \#1 \$text of function esc_attr expects string, int given\.$#'
                         identifier: argument.type
                         count: 1
@@ -810 +805 @@
                         path: ../../../src/wp-content/themes/twentynineteen/template-parts/post/author-bio.php
                 -
-                        message: '#^Parameter \#1 \$text of function esc_attr expects string, int\<0, max\> given\.$#'
+                        message: '#^Parameter \#1 \$text of function esc_attr expects string, int given\.$#'
                         identifier: argument.type
                         count: 1

trunk/tests/phpstan/baselines/notIdentical.alwaysTrue.neon

@@ -19 +19 @@
 parameters:
         ignoreErrors:
-                -
-                        message: '#^Strict comparison using \!\=\= between ''all'' and int will always evaluate to true\.$#'
-                        identifier: notIdentical.alwaysTrue
-                        count: 1
-                        path: ../../../src/wp-admin/includes/class-wp-links-list-table.php
                 -
                         message: '#^Strict comparison using \!\=\= between null and string will always evaluate to true\.$#'