Make WordPress Core

Changeset 63174


Ignore:
Timestamp:
08/11/2026 06:04:38 AM (2 months ago)
Author:
wildworks
Message:

Administration: Remove no-JS notices from route-based screens.

The Fonts and Connectors screens no longer render their own heading and JavaScript-required notice. The generated page template now provides both for every route-based screen, so the per-screen markup only produced a duplicate heading and notice when JavaScript was disabled.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/12946

Follow-up to [62954].
Props hbhalodia, wildworks.
Fixes #65840.

Location:
trunk/src/wp-admin
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/font-library.php

    r62954 r63174  
    2929
    3030// Set the page title
    31 $title               = _x( 'Fonts', 'Font Library admin page title' );
    32 $js_required_message = __( 'The Fonts screen requires JavaScript. Please enable JavaScript in your browser settings to install and manage fonts.' );
     31$title = _x( 'Fonts', 'Font Library admin page title' );
    3332
    3433require_once ABSPATH . 'wp-admin/admin-header.php';
    35 
    36 ?>
    37 <div class="wrap hide-if-js">
    38         <h1 class="wp-heading-inline"><?php echo esc_html( $title ); ?></h1>
    39         <?php
    40                 wp_admin_notice(
    41                         $js_required_message,
    42                         array(
    43                                 'type'               => 'error',
    44                                 'additional_classes' => array( 'hide-if-js' ),
    45                         )
    46                 );
    47                 ?>
    48 </div>
    49 <?php
    5034
    5135// Render the Font Library page
  • trunk/src/wp-admin/options-connectors.php

    r62954 r63174  
    2828
    2929// Set the page title.
    30 $title               = __( 'Connectors' );
    31 $js_required_message = __( 'The Connectors screen requires JavaScript. Please enable JavaScript in your browser settings to manage your connectors.' );
     30$title = __( 'Connectors' );
    3231
    3332// Set parent file for menu highlighting.
    … …  
    3635require_once ABSPATH . 'wp-admin/admin-header.php';
    3736
    38 ?>
    39 <div class="wrap hide-if-js">
    40         <h1 class="wp-heading-inline"><?php echo esc_html( $title ); ?></h1>
    41         <?php
    42                 wp_admin_notice(
    43                         $js_required_message,
    44                         array(
    45                                 'type'               => 'error',
    46                                 'additional_classes' => array( 'hide-if-js' ),
    47                         )
    48                 );
    49                 ?>
    50 </div>
    51 <?php
    52 
    5337// Render the Connectors page.
    5438wp_options_connectors_wp_admin_render_page();
Note: See TracChangeset for help on using the changeset viewer.