Changeset 63297

Timestamp:

08/14/2026 07:47:01 AM (8 hours ago)

Author:

westonruter

Message:

Code Modernization: Use array_key_first() for an array's first key.

current( array_keys( $array ) ) builds a complete array of every key only to read the first one and discard the rest, whereas array_key_first() reads the first bucket directly. The function has been native since PHP 7.3, below the current minimum supported version, and core already uses it in wp_replace_in_html_tags(). Behavior is unchanged: the toolbar's $actions cannot be empty at that point, and in the privacy tools absint() normalizes null and false alike.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/12785.
Follow-up to r18788, r42986.

Props mukesh27, soean.
Fixes #65773.

Location:

trunk/src

Files:

• wp-admin/includes/privacy-tools.php (modified) (1 diff)
• wp-includes/admin-bar.php (modified) (1 diff)

trunk/src/wp-admin/includes/privacy-tools.php

@@ -75 +75 @@
                 check_admin_referer( 'bulk-privacy_requests' );
 
-                $request_id = absint( current( array_keys( (array) wp_unslash( $_POST['privacy_action_email_retry'] ) ) ) );
+                $request_id = absint( array_key_first( (array) wp_unslash( $_POST['privacy_action_email_retry'] ) ) );
                 $result     = _wp_privacy_resend_request( $request_id );
 

trunk/src/wp-includes/admin-bar.php

@@ -1081 +1081 @@
                         'id'    => 'new-content',
                         'title' => $title,
-                        'href'  => admin_url( current( array_keys( $actions ) ) ),
+                        'href'  => admin_url( array_key_first( $actions ) ),
                         'meta'  => array(
                                 'menu_title' => _x( 'New', 'admin bar menu group label' ),