Changeset 63347

Timestamp:

08/25/2026 10:27:47 PM (17 hours ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Replace remaining join() aliases with implode().

join() is an alias of implode(). Using the canonical function name is strongly recommended, as aliases may be deprecated or removed without (much) warning. This replaces the last three uses of the alias in actively maintained PHP code.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13263.

Follow-up to [49193], [49200], [56616], [57567], [60704], [61326].

Props Soean, mukesh27.
See #65818.

Location:

trunk

Files:

• src/wp-includes/canonical.php (modified) (1 diff)
• tests/phpunit/tests/functions/wpGetArchives.php (modified) (1 diff)
• tests/phpunit/tests/script-modules/wpScriptModules.php (modified) (1 diff)

trunk/src/wp-includes/canonical.php

@@ -987 +987 @@
                                         return false;
                                 }
-                                $where .= " AND post_type IN ('" . join( "', '", esc_sql( $post_types ) ) . "')";
+                                $where .= " AND post_type IN ('" . implode( "', '", esc_sql( $post_types ) ) . "')";
                         } else {
                                 if ( ! in_array( get_query_var( 'post_type' ), $publicly_viewable_post_types, true ) ) {

trunk/tests/phpunit/tests/functions/wpGetArchives.php

@@ -221 +221 @@
                 $ids = array_slice( array_reverse( self::$post_ids ), 0, 3 );
 
-                $expected = join(
+                $expected = implode(
                         '',
                         array_map(

trunk/tests/phpunit/tests/script-modules/wpScriptModules.php

@@ -487 +487 @@
                                         $key_parts[] = sprintf( '%s_%s', $param_name, json_encode( $param_value ) );
                                 }
-                                $data[ join( '_', $key_parts ) ] = $test_case;
+                                $data[ implode( '_', $key_parts ) ] = $test_case;
                         }
                 }