Changeset 63366 for trunk/tests/phpunit/tests/functions/wpParseList.php

Timestamp:

08/27/2026 07:00:51 PM (6 weeks ago)

Author:

westonruter

Message:

Code Quality: Support passing an int to wp_parse_list() et al.

Passing an integer has worked since r44546 consolidated this parsing on preg_split(), which coerces it to a string, but the declared mixed[]|string parameter type never allowed for it. The type is widened to mixed[]|string|int for wp_parse_list(), wp_parse_id_list(), and wp_parse_slug_list(). The wp_parse_list() function now converts an integer explicitly instead of relying on that coercion. Behavior is unchanged, and tests are added for integer input. A float or a bool is also coerced today, but neither is meaningful for a list of IDs or slugs, so both are left undocumented.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13297.
Follow-up to r44546, r62797, r62835.

See #65817.

File:

• trunk/tests/phpunit/tests/functions/wpParseList.php (modified) (3 diffs)

trunk/tests/phpunit/tests/functions/wpParseList.php

@@ -15 +15 @@
          * @dataProvider data_wp_parse_list
          *
-         * @param mixed[]|string $input_list
+         * @param mixed[]|string|int $input_list
          * @param array<scalar> $expected
          */
@@ -36 +36 @@
          * Data provider.
          *
-         * @return array<string, array{ input_list: mixed[]|string, expected: array<scalar> }>
+         * @return array<string, array{ input_list: mixed[]|string|int, expected: array<scalar> }>
          */
         public function data_wp_parse_list(): array {
@@ -84 +84 @@
                                 'expected'   => array(),
                         ),
+                        'positive int'        => array(
+                                'input_list' => 5,
+                                'expected'   => array( '5' ),
+                        ),
+                        'negative int'        => array(
+                                'input_list' => -5,
+                                'expected'   => array( '-5' ),
+                        ),
+                        'zero'                => array(
+                                'input_list' => 0,
+                                'expected'   => array( '0' ),
+                        ),
+                        'comma in array item' => array(
+                                'input_list' => array( '1,2' ),
+                                'expected'   => array( '1,2' ),
+                        ),
                         'passed scalar array' => array(
                                 'input_list' => array( 'foo', true, false, 1, 3.14 ),