Changeset 63400

Timestamp:

08/30/2026 10:31:20 PM (25 hours ago)

Author:

peterwilsoncc

Message:

Embeds: Update click handler to follow deeply nested links.

Update linkClickHandler() to follow links with nested sub elements within the _top window, for example <a href="http://wordpress.org"><span><span>WordPress</span></span>></a>.

Previously the link handler only handled links with single nested elements, links further nested would open within the iframe.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13244.

Props khokansardar, swissspidy, westonruter.
Fixes #65947.

File:

• trunk/src/js/_enqueues/lib/embed-template.js (modified) (1 diff)

trunk/src/js/_enqueues/lib/embed-template.js

@@ -157 +157 @@
                  */
                 function linkClickHandler( e ) {
-                        var target = e.target,
-                                href;
-                        if ( target.hasAttribute( 'href' ) ) {
-                                href = target.getAttribute( 'href' );
-                        } else {
-                                href = target.parentElement.getAttribute( 'href' );
-                        }
+                        /*
+                         * The href property resolves to an absolute URL, which the parent window requires.
+                         * Elements whose href is not a string, such as SVG anchors, are skipped.
+                         */
+                        var link = e.target.closest( '[href]' ),
+                                href = 'string' === typeof link?.href ? link.href : null;
 
                         // Only catch clicks from the primary mouse button, without any modifiers.