Changeset 63401

Timestamp:

08/30/2026 10:42:49 PM (2 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertIsNotArray() for array type assertions.

Tests_Theme::test_get_theme() wraps a native type check in a boolean assertion. PHPUnit has a dedicated assertion for this, which states the intent directly and reports a more useful message when it fails. The comment above it is reworded for clarity.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13305.

Follow-up to r62761, r63311.

Props Soean, mukesh27, SergeyBiryukov.
See #65819.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme.php

@@ -95 +95 @@
                 foreach ( array_keys( $themes ) as $name ) {
                         $theme = get_theme( $name );
-                        // WP_Theme implements ArrayAccess. Even ArrayObject returns false for is_array().
-                        $this->assertFalse( is_array( $theme ) );
+                        // WP_Theme implements ArrayAccess, but that does not make it an array:
+                        // is_array() returns false for ArrayObject.
+                        $this->assertIsNotArray( $theme );
                         $this->assertInstanceOf( 'WP_Theme', $theme );
                         $this->assertSame( $theme, $themes[ $name ] );