Changeset 63489

Timestamp:

09/05/2026 05:26:08 AM (4 weeks ago)

Author:

westonruter

Message:

Editor: Skip state styles for blocks without a style attribute.

The wp_render_block_states_support() function is hooked on render_block, so it runs once per block on every front-end request. Before it could determine that a block has no state styles, it resolved the block type from the registry, called wp_get_global_settings(), and computed responsive media queries; all of this work is discarded for the overwhelming majority of blocks, which carry no style attribute at all.

Every CSS rule the function can produce is keyed off the block's style attribute, and the function already returns the content unchanged when no rules are generated. Resolving style first and returning early when it is absent is therefore behavior-preserving.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13051 and ​https://github.com/WordPress/gutenberg/pull/81908.
Follow-up to r62453, r62671.

Reviewed by adamsilverstein.
Merges r63474 to the 7.1 branch.

Props mukesh27, westonruter, adamsilverstein, wildworks.
Fixes #65929.

Location:

branches/7.1

Files:

• . (modified) (1 prop)
• src/wp-includes/block-supports/states.php (modified) (2 diffs)

branches/7.1/src/wp-includes/block-supports/states.php

@@ -543 +543 @@
         }
 
+        /*
+         * Every CSS rule this function can produce is keyed off the block's `style`
+         * attribute. Without it there is nothing to generate, so bail before doing
+         * any of the lookups below — this runs for every block on every request.
+         */
+        $style = $block['attrs']['style'] ?? array();
+        if ( empty( $style ) || ! is_array( $style ) ) {
+                return $block_content;
+        }
+
         $block_name = $block['blockName'];
         $block_type = WP_Block_Type_Registry::get_instance()->get_registered( $block_name );
@@ -550 +560 @@
 
         $supported_pseudo_states  = WP_Theme_JSON::VALID_BLOCK_PSEUDO_SELECTORS[ $block_name ] ?? array();
-        $style                    = $block['attrs']['style'] ?? array();
         $css_rules                = array();
         $viewport_settings        = wp_get_global_settings( array( 'viewport' ) );