Changeset 63562

Timestamp:

09/09/2026 02:30:58 PM (3 weeks ago)

Author:

lancewillett

Message:

Tests: Simplify mocks in WP_Upgrader tests.

Use createMock() for the upgrader skin and filesystem mocks. These test doubles need no custom builder configuration, original constructor, or cloning behavior.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13458

Props soean.
See #65819.

File:

• trunk/tests/phpunit/tests/admin/wpUpgrader.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/wpUpgrader.php

@@ -50 +50 @@
                 parent::set_up();
 
-                self::$upgrader_skin_mock = $this->getMockBuilder( 'WP_Upgrader_Skin' )->getMock();
+                self::$upgrader_skin_mock = $this->createMock( 'WP_Upgrader_Skin' );
 
                 self::$instance = new WP_Upgrader( self::$upgrader_skin_mock );
 
-                self::$wp_filesystem_mock = $this->getMockBuilder( 'WP_Filesystem_Base' )->getMock();
+                self::$wp_filesystem_mock = $this->createMock( 'WP_Filesystem_Base' );
 
                 if ( array_key_exists( 'wp_filesystem', $GLOBALS ) ) {