Changeset 63579

Timestamp:

09/10/2026 10:48:20 AM (23 hours ago)

Author:

jonsurrell

Message:

Script Loader: Avoid a false entry in inline script data.

WP_Scripts::get_data() returns false when a handle has no before or after data, and casting that to an array produced array( false ). The first inline script added for a handle was therefore stored after an unused false entry. Missing inline script data is now treated as an empty array.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/12217

Follow-up to r36633.

Props vanyukov, sukhendu2002, jonsurrell, apermo.
Fixes #52320.

Location:

trunk

Files:

• src/wp-includes/class-wp-scripts.php (modified) (1 diff)
• tests/phpunit/tests/dependencies/scripts.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-scripts.php

@@ -528 +528 @@
                 }
 
-                $script   = (array) $this->get_data( $handle, $position );
+                $script   = $this->get_data( $handle, $position );
+                $script   = false === $script ? array() : (array) $script;
                 $script[] = $data;
 

trunk/tests/phpunit/tests/dependencies/scripts.php

@@ -228 +228 @@
                         'defer' => array( 'defer' ),
                         'async' => array( 'async' ),
+                );
+        }
+
+        /**
+         * Tests that inline scripts do not include a false entry when no data exists yet.
+         *
+         * @ticket 52320
+         * @dataProvider data_inline_script_positions
+         *
+         * @param string $position Inline script position.
+         */
+        public function test_add_inline_script_does_not_store_false_for_empty_existing_data( $position ): void {
+                $handle = 'test-inline-script-' . $position;
+
+                wp_register_script( $handle, '/test.js', array(), null );
+                wp_add_inline_script( $handle, 'console.log( "test" );', $position );
+
+                $this->assertSame(
+                        array( 'console.log( "test" );' ),
+                        wp_scripts()->get_data( $handle, $position )
+                );
+        }
+
+        /**
+         * Data provider for inline script positions.
+         *
+         * @return array<string, array{0: string}> Inline script positions.
+         */
+        public function data_inline_script_positions(): array {
+                return array(
+                        'before' => array( 'before' ),
+                        'after'  => array( 'after' ),
                 );
         }