Changeset 63604

Timestamp:

09/11/2026 08:59:28 PM (5 weeks ago)

Author:

lancewillett

Message:

Tests: Use assertSame() in WP_Customize_Nav_Menu_Item_Setting tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Where a loose comparison is intentional, inline comments now explain why: post meta returns IDs as strings, and some objects are compared by value.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13451

Props r1k0, mukesh27.
See #64895.

Location:

trunk/tests/phpunit/tests/customize

Files:

• nav-menu-item-setting.php (modified) (5 diffs)
• nav-menu-setting.php (modified) (2 diffs)
• widgets.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/nav-menu-item-setting.php

@@ -191 +191 @@
                 $this->assertSame( $menu_item->title, $value['title'] );
                 $this->assertSame( $menu_item->type, $value['type'] );
-                $this->assertEquals( $menu_item->object_id, $value['object_id'] );
+                $this->assertSame( (int) $menu_item->object_id, $value['object_id'] );
                 $this->assertSame( $menu_id, $value['nav_menu_term_id'] );
                 $this->assertSame( 'Hello World', $value['original_title'] );
@@ -274 +274 @@
                 $this->assertSame( $menu_item->title, $value['title'] );
                 $this->assertSame( $menu_item->type, $value['type'] );
-                $this->assertEquals( $menu_item->object_id, $value['object_id'] );
+                $this->assertSame( (int) $menu_item->object_id, $value['object_id'] );
                 $this->assertSame( $menu_id, $value['nav_menu_term_id'] );
                 $this->assertSame( 'Salutations', $value['original_title'] );
@@ -633 +633 @@
                 $nav_menu_item = wp_setup_nav_menu_item( clone $post );
 
+                /*
+                 * Keep assertEquals() because sanitize() returns object_id as an integer
+                 * while wp_setup_nav_menu_item() retrieves it as a string from post meta.
+                 */
                 $this->assertEquals( $expected_sanitized['object_id'], $nav_menu_item->object_id );
                 $this->assertSame( $expected_sanitized['object'], $nav_menu_item->object );
+
+                /*
+                 * Keep assertEquals() because sanitize() returns menu_item_parent as an integer,
+                 * while wp_setup_nav_menu_item() retrieves it as a string from post meta.
+                 */
                 $this->assertEquals( $expected_sanitized['menu_item_parent'], $nav_menu_item->menu_item_parent );
                 $this->assertSame( $expected_sanitized['position'], $post->menu_order );
@@ -698 +707 @@
                 $post_value['post_status'] = $post_value['status'];
                 unset( $post_value['status'] );
+
+                /*
+                 * Keep assertEquals() because object_id is an integer in $post_value
+                 * but is returned as a string from post meta by wp_setup_nav_menu_item().
+                 */
                 foreach ( $post_value as $key => $value ) {
                         $this->assertEquals( $value, $updated_item->$key, "Key $key mismatch" );
@@ -771 +785 @@
                 $post_value['menu_order'] = $post_value['position'];
                 unset( $post_value['position'] );
+
+                /*
+                 * Keep assertEquals() because object_id is an integer in $post_value
+                 * but is returned as a string from post meta by wp_setup_nav_menu_item().
+                 */
                 foreach ( $post_value as $key => $value ) {
                         $this->assertEquals( $value, $last_item->$key, "Mismatch for $key property." );

trunk/tests/phpunit/tests/customize/nav-menu-setting.php

@@ -233 +233 @@
 
                 $menu_object = wp_get_nav_menu_object( $menu_id );
+
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( (object) $term, $menu_object );
                 $this->assertSame( $post_value['name'], $menu_object->name );
@@ -278 +280 @@
 
                 $menu_object = wp_get_nav_menu_object( $menu_id );
+
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( (object) $term, $menu_object );
                 $this->assertSame( $post_value['name'], $menu_object->name );

trunk/tests/phpunit/tests/customize/widgets.php

@@ -516 +516 @@
                 $this->assertTrue( $sanitized_for_js['is_widget_customizer_js_value'] );
                 $this->assertArrayHasKey( 'instance_hash_key', $sanitized_for_js );
+
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( (object) $block_instance, $sanitized_for_js['raw_instance'] );