Changeset 63787

Timestamp:

09/21/2026 09:49:58 PM (13 hours ago)

Author:

westonruter

Message:

Build/Test Tools: Update PHPStan to 2.2.14.

The release improves how conditional expressions are propagated through derived assignments and through overlapping ternary arms, so four variable.undefined errors drop out of the baseline: the three occurrences of $metakey in add_meta(), where the enclosing condition already guarantees that one of the two assignments has run, and $token_length in WP_HTML_Decoder::attribute_starts_with(), which is written by reference by read_character_reference() in the ternary arm selected by the subsequent null check.

The baselines are regenerated for the new version, with tests/phpstan/baselines/variable.undefined.neon the only one that changed. The release also carries a batch of performance improvements, continuing the trend noted in r63510.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13645.
Follow-up to r63019, r63510.

See #65817.

Location:

trunk

Files:

• composer.json (modified) (1 diff)
• tests/phpstan/baselines/variable.undefined.neon (modified) (2 diffs)

trunk/composer.json

@@ -53 +53 @@
                 "wp-coding-standards/wpcs": "~3.4.1",
                 "phpcompatibility/phpcompatibility-wp": "~2.1.3",
-                "phpstan/phpstan": "2.2.13",
+                "phpstan/phpstan": "2.2.14",
                 "phpstan/phpstan-phpunit": "2.0.18",
                 "yoast/phpunit-polyfills": "^1.1.0"

trunk/tests/phpstan/baselines/variable.undefined.neon

@@ -275 +275 @@
                         path: ../../../src/wp-admin/includes/plugin.php
                 -
-                        message: '#^Variable \$metakey might not be defined\.$#'
-                        identifier: variable.undefined
-                        count: 3
-                        path: ../../../src/wp-admin/includes/post.php
-                -
                         message: '#^Variable \$revision might not be defined\.$#'
                         identifier: variable.undefined
@@ -880 +875 @@
                         path: ../../../src/wp-includes/global-styles-and-settings.php
                 -
-                        message: '#^Variable \$token_length might not be defined\.$#'
-                        identifier: variable.undefined
-                        count: 1
-                        path: ../../../src/wp-includes/html-api/class-wp-html-decoder.php
-                -
                         message: '#^Variable \$node might not be defined\.$#'
                         identifier: variable.undefined