Changeset 63920

Timestamp:

09/24/2026 06:12:30 PM (9 days ago)

Author:

lancewillett

Message:

Build/Test Tools: Check database readiness over TCP.

Ping the local Docker database over TCP so its healthcheck waits for the server to accept network connections.

Merges [63871] partially to the 7.1 branch.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13686

Reviewed by: jorbin.
Props lucatume.
See #66117.

Location:

branches/7.1

Files:

• . (modified) (1 prop)
• docker-compose.yml (modified) (1 diff)
• tools/local-env/scripts/install.js (modified) (1 diff)

branches/7.1/docker-compose.yml

@@ -80 +80 @@
       - mysql:/var/lib/mysql
 
+    # Ping over TCP: the client resolves the literal `localhost` to the Unix socket, which the
+    # temporary `--skip-networking` server used to initialise a cold volume answers long before
+    # the real server listens on port 3306.
     healthcheck:
       test: [
         'CMD-SHELL',
-        'if [ "$LOCAL_DB_TYPE" = "mariadb" ]; then case "$LOCAL_DB_VERSION" in 5.5|10.0|10.1|10.2|10.3) mysqladmin ping -h localhost || exit $$?;; *) mariadb-admin ping -h localhost || exit $$?;; esac; else mysqladmin ping -h localhost || exit $$?; fi'
+        'if [ "$LOCAL_DB_TYPE" = "mariadb" ]; then case "$LOCAL_DB_VERSION" in 5.5|10.0|10.1|10.2|10.3) mysqladmin ping -h 127.0.0.1 --protocol=tcp || exit $$?;; *) mariadb-admin ping -h 127.0.0.1 --protocol=tcp || exit $$?;; esac; else mysqladmin ping -h 127.0.0.1 --protocol=tcp || exit $$?; fi'
       ]
       timeout: 5s

branches/7.1/tools/local-env/scripts/install.js

@@ -10 +10 @@
 dotenvExpand.expand( dotenv.config() );
 
-// Create wp-config.php. This verifies the database connection, so retrying it doubles as the
-// readiness probe: the mysql healthcheck pings the container's own socket, which the temporary
-// server used to initialise a cold volume answers before the real server listens on TCP.
+// Create wp-config.php. This verifies the database connection, so retrying it keeps
+// `env:install` working on its own, without `env:start` having waited for the mysql
+// container to report healthy first.
 wp_cli_retry(
         `config create --dbname=wordpress_develop --dbuser=root --dbpass=password --dbhost=mysql --force --config-file="wp-config.php"`,