Changeset 63936

Timestamp:

09/25/2026 03:31:07 PM (5 days ago)

Author:

lancewillett

Message:

Tests: Replace native assertions in PHPUnit test classes.

Use PHPUnit type assertions in test setup and helpers so checks remain active when native PHP assertions are disabled and report failures through PHPUnit.

Retain native assertions outside PHPUnit test classes and add messages describing their invariants.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13651

Props soean.
See #64895.

Location:

trunk/tests

Files:

• phpstan/GlobalDocBlockVisitor.php (modified) (1 diff)
• phpunit/tests/comment/wpNotifyNoteMentions.php (modified) (1 diff)
• phpunit/tests/dependencies/scripts.php (modified) (1 diff)
• phpunit/tests/post/getPost.php (modified) (1 diff)
• phpunit/tests/privacy/wpPrivacyResetPolicyPageForPost.php (modified) (1 diff)

trunk/tests/phpstan/GlobalDocBlockVisitor.php

@@ -166 +166 @@
                         foreach ( $matches as $match ) {
                                 $type = preg_replace( '/\s+/', '', $match['type'] );
-                                assert( is_string( $type ) && '' !== $type );
+                                assert( is_string( $type ) && '' !== $type, 'Collapsing whitespace in a non-empty type must yield a non-empty string.' );
                                 $map[ $match['variable'] ] = $type;
                         }

trunk/tests/phpunit/tests/comment/wpNotifyNoteMentions.php

@@ -122 +122 @@
                         )
                 );
-                assert( $comment instanceof WP_Comment );
+                $this->assertInstanceOf( WP_Comment::class, $comment );
                 return $comment;
         }

trunk/tests/phpunit/tests/dependencies/scripts.php

@@ -102 +102 @@
                 $find_id_tag_processor->next_token();
                 $id = $find_id_tag_processor->get_attribute( 'id' );
-                assert( is_string( $id ) );
+                $this->assertIsString( $id, 'The expected SCRIPT tag must have an ID attribute.' );
 
                 $processor = ( new class('', WP_HTML_Processor::CONSTRUCTOR_UNLOCK_CODE ) extends WP_HTML_Processor {
                         public function get_script_html() {
-                                assert( 'SCRIPT' === $this->get_tag() );
+                                assert( 'SCRIPT' === $this->get_tag(), 'The processor must be paused on a SCRIPT tag.' );
                                 $this->set_bookmark( 'here' );
                                 $span = $this->bookmarks['_here'];

trunk/tests/phpunit/tests/post/getPost.php

@@ -14 +14 @@
                 parent::set_up_before_class();
                 $post_id = self::factory()->post->create();
-                assert( is_int( $post_id ) );
+                self::assertIsInt( $post_id );
                 self::$post_id = $post_id;
 

trunk/tests/phpunit/tests/privacy/wpPrivacyResetPolicyPageForPost.php

@@ -22 +22 @@
 
                 $page_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
-                assert( is_int( $page_id ) );
+                $this->assertIsInt( $page_id );
                 $this->policy_page_id = $page_id;
                 update_option( 'wp_page_for_privacy_policy', $this->policy_page_id );