Changeset 63978

Timestamp:

09/28/2026 05:19:05 PM (43 hours ago)

Author:

lancewillett

Message:

Build/Test Tools: Check database readiness over TCP.

Use TCP for the database healthcheck so the temporary initialization server does not report readiness before the real server accepts connections. Use mysqladmin for older MariaDB versions and preserve failed ping status.

Merges the docker-compose.yml changes from [59484], [59489], and [63871] to the 6.7 branch.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13749

Reviewed by: jorbin.
Props lucatume.
See #66117.

File:

• branches/6.7/docker-compose.yml (modified) (1 diff, 1 prop)

branches/6.7/docker-compose.yml

@@ -82 +82 @@
     command: ${LOCAL_DB_AUTH_OPTION-}
 
+    # Ping over TCP: the client resolves the literal `localhost` to the Unix socket, which the
+    # temporary `--skip-networking` server used to initialise a cold volume answers long before
+    # the real server listens on port 3306.
     healthcheck:
-      test: [ "CMD-SHELL", "if [ \"$LOCAL_DB_TYPE\" = \"mariadb\" ]; then mariadb-admin ping -h localhost; else mysqladmin ping -h localhost; fi" ]
+      test: [
+        'CMD-SHELL',
+        'if [ "$LOCAL_DB_TYPE" = "mariadb" ]; then case "$LOCAL_DB_VERSION" in 5.5|10.0|10.1|10.2|10.3) mysqladmin ping -h 127.0.0.1 --protocol=tcp || exit $$?;; *) mariadb-admin ping -h 127.0.0.1 --protocol=tcp || exit $$?;; esac; else mysqladmin ping -h 127.0.0.1 --protocol=tcp || exit $$?; fi'
+      ]
       timeout: 5s
       interval: 5s