Changeset 64016

Timestamp:

09/30/2026 03:39:47 PM (13 hours ago)

Author:

lancewillett

Message:

Tests: Improve isolation for randomized query tests.

Save and restore the sticky_posts option around the sticky-query test class to prevent its shared fixtures from affecting other tests.

Regenerate canonical rewrite rules after registering the initial taxonomies, and use the recognized ID orderby value to select child posts deterministically.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13188

Props jonsurrell, adrianmoldovanwp.
See #65893.

Location:

trunk/tests/phpunit

Files:

• includes/testcase-canonical.php (modified) (1 diff)
• tests/query/stickies.php (modified) (2 diffs)
• tests/query/thePost.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase-canonical.php

@@ -33 +33 @@
                 $this->set_permalink_structure( $this->structure );
                 create_initial_taxonomies();
+                flush_rewrite_rules( false );
         }
 

trunk/tests/phpunit/tests/query/stickies.php

@@ -9 +9 @@
 class Tests_Query_Stickies extends WP_UnitTestCase {
         public static $posts = array();
+        private static $original_sticky_posts;
 
         public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+                self::$original_sticky_posts = get_option( 'sticky_posts' );
+                update_option( 'sticky_posts', array() );
+
                 // Set post times to get a reliable order.
                 $now = time();
@@ -25 +29 @@
                 stick_post( self::$posts[14] );
                 stick_post( self::$posts[8] );
+        }
+
+        public static function wpTearDownAfterClass() {
+                update_option( 'sticky_posts', self::$original_sticky_posts );
         }
 

trunk/tests/phpunit/tests/query/thePost.php

@@ -111 +111 @@
                                 'post_type' => 'page',
                                 'post__in'  => self::$page_child_ids,
-                                'orderby'   => 'id',
+                                'orderby'   => 'ID',
                                 'order'     => 'ASC',
                         )