Changeset 64071

Timestamp:

10/02/2026 08:03:38 PM (2 days ago)

Author:

lancewillett

Message:

Tests: Document object value comparisons in post tests.

Explain why post lookup, metadata, post type label, and attachment count tests retain assertEquals() when comparing separately constructed or cached objects by value.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13939

Props noruzzaman.
See #64895.

Location:

trunk/tests/phpunit/tests/post

Files:

• getPageByPath.php (modified) (1 diff)
• meta.php (modified) (2 diffs)
• types.php (modified) (1 diff)
• wpCountAttachments.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/getPageByPath.php

@@ -39 +39 @@
 
                 // get_page_by_path() should return a post of the requested type before returning an attachment.
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $page, get_page_by_path( 'some-page' ) );
 
                 // Make sure get_page_by_path() will still select an attachment when a post of the requested type doesn't exist.
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $other_att, get_page_by_path( 'some-other-page' ) );
         }

trunk/tests/phpunit/tests/post/meta.php

@@ -172 +172 @@
                 $mobj->meta_key   = 'get_post_meta_by_key';
                 $mobj->meta_value = 'get_post_meta_by_key_value';
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $mobj, get_post_meta_by_id( $mid ) );
                 delete_metadata_by_mid( 'post', $mid );
@@ -179 +180 @@
                 $mobj->meta_id    = $mid;
                 $mobj->meta_value = array( 'foo', 'bar' );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $mobj, get_post_meta_by_id( $mid ) );
                 delete_metadata_by_mid( 'post', $mid );

trunk/tests/phpunit/tests/post/types.php

@@ -293 +293 @@
                 $after = get_post_type_object( 'foo' )->labels;
 
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $before, $after );
 

trunk/tests/phpunit/tests/post/wpCountAttachments.php

@@ -29 +29 @@
                 $actual   = wp_cache_get( $cache_key, 'counts' );
 
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $expected, $actual );
         }