Changeset 64105

Timestamp:

10/05/2026 06:51:55 PM (2 weeks ago)

Author:

lancewillett

Message:

Tests: Document post object value comparisons.

Explain why the sample permalink tests retain assertEquals() when checking that the original WP_Post properties remain unchanged.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13993

Props noruzzaman.
See #64895.

File:

• trunk/tests/phpunit/tests/admin/includesPost.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -968 +968 @@
                         'get_sample_permalink',
                         function ( $permalink, $post_id, $title, $name, $post ) use ( $post_original ) {
+                                // Keep assertEquals() because the objects are intentionally compared by value.
                                 $this->assertEquals( $post_original, $post, 'Modified post object passed to get_sample_permalink filter.' );
                                 return $permalink;
@@ -976 +977 @@
 
                 get_sample_permalink( $post );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $post_original, $post, 'get_sample_permalink() modifies the post object.' );
         }