Changeset 64111

Timestamp:

10/05/2026 07:03:12 PM (2 weeks ago)

Author:

lancewillett

Message:

Tests: Clarify comparisons in top-level test files.

Use assertSame() with a string expectation for the memory limit. Document intentional object-value comparisons and numeric-string differences in user properties.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14000

Props noruzzaman.
See #64895.

Location:

trunk/tests/phpunit/tests

Files:

• cache.php (modified) (1 diff)
• functions.php (modified) (2 diffs)
• json-schema.php (modified) (1 diff)
• post.php (modified) (1 diff)
• query.php (modified) (2 diffs)
• theme.php (modified) (2 diffs)
• user.php (modified) (2 diffs)

trunk/tests/phpunit/tests/cache.php

@@ -404 +404 @@
                         $this->assertInstanceOf( 'WP_Object_Cache', $wp_object_cache );
                 } else {
+                        // Keep assertEquals() because the objects are intentionally compared by value.
                         $this->assertEquals( $wp_object_cache, $new_blank_cache_object );
                 }

trunk/tests/phpunit/tests/functions.php

@@ -1113 +1113 @@
                 $this->assertNotEmpty( $date_return, 'The date return could not be an empty string' );
                 $this->assertSame( $expected, $date_return, 'The date does not match' );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( new DateTime( $expected ), new DateTime( $date_return ), 'The date is not the same after the call method' );
         }
@@ -1182 +1183 @@
                 $this->assertSame( $ini_limit_before, $ini_limit_after );
                 $this->assertFalse( $raised_limit );
-                $this->assertEquals( WP_MAX_MEMORY_LIMIT, $ini_limit_after );
+                $this->assertSame( (string) WP_MAX_MEMORY_LIMIT, $ini_limit_after );
         }
 

trunk/tests/phpunit/tests/json-schema.php

@@ -132 +132 @@
                 $this->assertArrayNotHasKey( 'required', $prepared['properties']['title'] );
                 $this->assertArrayNotHasKey( 'validate_callback', $prepared['properties']['title'] );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( new stdClass(), $prepared['properties']['settings']['default'] );
                 $this->assertSame( array( 'settings' ), $prepared['dependencies']['title'] );

trunk/tests/phpunit/tests/post.php

@@ -188 +188 @@
                 _unregister_post_type( $post_type );
                 $count = wp_count_posts( $post_type, 'readable' );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( new stdClass(), $count );
         }

trunk/tests/phpunit/tests/query.php

@@ -77 +77 @@
                 $this->assertEmpty( get_query_var( 'tax_query' ) );
                 $this->assertCount( 1, get_query_var( 'tag_slug__in' ) );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( get_queried_object(), $tag );
 
@@ -88 +89 @@
                 $this->assertNotEmpty( $query->get( 'tag' ) );
                 $this->assertCount( 1, $query->get( 'tag_slug__in' ) );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $query->get_queried_object(), $tag );
         }

trunk/tests/phpunit/tests/theme.php

@@ -80 +80 @@
                 $single_theme = wp_get_theme( $this->theme_slug );
                 $this->assertSame( $single_theme->get( 'Name' ), $themes[ $this->theme_slug ]->get( 'Name' ) );
+                // Keep assertEquals() because the objects are intentionally compared by value.
                 $this->assertEquals( $themes[ $this->theme_slug ], $single_theme );
         }
@@ -127 +128 @@
                         // This primes internal WP_Theme caches for the next assertion (headers_sanitized, textdomain_loaded).
                         $this->assertSame( $theme->get( 'Name' ), $_theme->get( 'Name' ) );
+                        // Keep assertEquals() because the objects are intentionally compared by value.
                         $this->assertEquals( $theme, $_theme );
                 }

trunk/tests/phpunit/tests/user.php

@@ -219 +219 @@
                 $user = new WP_User( self::$author_id );
 
+                // Keep assertEquals() because the public ID is an integer while data->ID may be a numeric string.
                 foreach ( $user->data as $key => $data ) {
                         $this->assertEquals( $data, $user->$key );
@@ -450 +451 @@
 
                 $user = new WP_User( self::$author_id );
+                // Keep assertEquals() because integer preference flags and the user ID may be retrieved as numeric strings.
                 foreach ( $user_data as $key => $value ) {
                         $this->assertEquals( $value, $user->get( $key ), $key );