Changeset 64244

Timestamp:

10/08/2026 03:04:03 PM (4 hours ago)

Author:

SergeyBiryukov

Message:

Code Quality: Remove an always-true check when clearing the 404 error in WP class.

In WP::parse_request(), $error is set to '404' and is not changed again before the '404' === $error check that clears it once a rewrite rule matches. The check therefore always passes and is removed. There is no change in behavior.

This resolves one error in the identical.alwaysTrue PHPStan baseline.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/14006.

Follow-up to r2627, r21818, r56362.

Props Soean.
See #65817.

Location:

trunk

Files:

• src/wp-includes/class-wp.php (modified) (1 diff)
• tests/phpstan/baselines/identical.alwaysTrue.neon (modified) (1 diff)

trunk/src/wp-includes/class-wp.php

@@ -278 +278 @@
                                 parse_str( $query, $perma_query_vars );
 
-                                // If we're processing a 404 request, clear the error var since we found something.
-                                if ( '404' === $error ) {
-                                        unset( $error, $_GET['error'] );
-                                }
+                                // Clear the 404 error var since we found something.
+                                unset( $error, $_GET['error'] );
                         }
 

trunk/tests/phpstan/baselines/identical.alwaysTrue.neon

@@ -25 +25 @@
                         path: ../../../src/wp-admin/includes/class-file-upload-upgrader.php
                 -
-                        message: '#^Strict comparison using \=\=\= between ''404'' and ''404'' will always evaluate to true\.$#'
-                        identifier: identical.alwaysTrue
-                        count: 1
-                        path: ../../../src/wp-includes/class-wp.php
-                -
                         message: '#^Strict comparison using \=\=\= between true and true will always evaluate to true\.$#'
                         identifier: identical.alwaysTrue