Changeset 64260

Timestamp:

10/09/2026 06:00:42 PM (4 hours ago)

Author:

lancewillett

Message:

Tests: Reduce REST attachment quality fixture overhead.

Create attachment records with static image metadata for the three REST image quality response tests instead of uploading a JPEG and generating thumbnails. Preserve the requests, filters, and assertions while removing the unnecessary imagejpeg() requirements.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14026

Props abcd95.
See #66074.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -2157 +2157 @@
         /**
          * @ticket 65262
-         * @requires function imagejpeg
          */
         public function test_image_quality_default_in_response() {
                 wp_set_current_user( self::$editor_id );
-                $attachment = self::factory()->attachment->create_upload_object( self::$test_file );
+                $attachment = $this->create_image_quality_test_attachment();
 
                 $request = new WP_REST_Request( 'GET', "/wp/v2/media/{$attachment}" );
@@ -2177 +2176 @@
         /**
          * @ticket 65262
-         * @requires function imagejpeg
          */
         public function test_image_quality_with_size_aware_filter() {
                 wp_set_current_user( self::$editor_id );
-                $attachment = self::factory()->attachment->create_upload_object( self::$test_file );
+                $attachment = $this->create_image_quality_test_attachment();
 
                 // Lower the quality for small images (e.g. thumbnails) only.
@@ -2213 +2211 @@
          *
          * @ticket 65262
-         * @requires function imagejpeg
          */
         public function test_image_quality_honors_jpeg_quality_filter() {
                 wp_set_current_user( self::$editor_id );
-                $attachment = self::factory()->attachment->create_upload_object( self::$test_file );
+                $attachment = $this->create_image_quality_test_attachment();
 
                 $filter = static function () {
@@ -2234 +2231 @@
                 // JPEG output, so the jpeg_quality filter overrides the 82 default.
                 $this->assertSame( 70, $data['image_quality']['default'] );
+        }
+
+        /**
+         * Creates a JPEG attachment with static metadata for image quality tests.
+         *
+         * Quality reporting uses the MIME type, full-size dimensions, and registered
+         * image sizes, so no upload or generated thumbnails are needed.
+         *
+         * @return int Attachment post ID.
+         */
+        private function create_image_quality_test_attachment() {
+                $attachment_id = self::factory()->attachment->create(
+                        array(
+                                'post_mime_type' => 'image/jpeg',
+                                'post_status'    => 'inherit',
+                                'file'           => 'canola.jpg',
+                        )
+                );
+
+                wp_update_attachment_metadata(
+                        $attachment_id,
+                        array(
+                                'width'  => 640,
+                                'height' => 480,
+                                'file'   => 'canola.jpg',
+                        )
+                );
+
+                return $attachment_id;
         }