Changeset 64263

Timestamp:

10/10/2026 10:56:13 AM (13 days ago)

Author:

lancewillett

Message:

Tests: Use strict assertions for Customizer menu item metadata.

Replace remaining assertEquals() calls in tests/phpunit/tests/customize/nav-menu-item-setting.php with assertSame(). Cast expected object_id and menu_item_parent values to strings to match the metadata returned by wp_setup_nav_menu_item().

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14066

Props shailu25.
See #64895.

File:

• trunk/tests/phpunit/tests/customize/nav-menu-item-setting.php (modified) (3 diffs)

trunk/tests/phpunit/tests/customize/nav-menu-item-setting.php

@@ -633 +633 @@
                 $nav_menu_item = wp_setup_nav_menu_item( clone $post );
 
-                /*
-                 * Keep assertEquals() because sanitize() returns object_id as an integer
-                 * while wp_setup_nav_menu_item() retrieves it as a string from post meta.
-                 */
-                $this->assertEquals( $expected_sanitized['object_id'], $nav_menu_item->object_id );
+                // Cast expected IDs to strings to match post meta values from wp_setup_nav_menu_item().
+                $this->assertSame( (string) $expected_sanitized['object_id'], $nav_menu_item->object_id );
                 $this->assertSame( $expected_sanitized['object'], $nav_menu_item->object );
-
-                /*
-                 * Keep assertEquals() because sanitize() returns menu_item_parent as an integer,
-                 * while wp_setup_nav_menu_item() retrieves it as a string from post meta.
-                 */
-                $this->assertEquals( $expected_sanitized['menu_item_parent'], $nav_menu_item->menu_item_parent );
+                $this->assertSame( (string) $expected_sanitized['menu_item_parent'], $nav_menu_item->menu_item_parent );
                 $this->assertSame( $expected_sanitized['position'], $post->menu_order );
                 $this->assertSame( $expected_sanitized['type'], $nav_menu_item->type );
@@ -708 +700 @@
                 unset( $post_value['status'] );
 
-                /*
-                 * Keep assertEquals() because object_id is an integer in $post_value
-                 * but is returned as a string from post meta by wp_setup_nav_menu_item().
-                 */
+                // Cast object_id to string to match post meta values from wp_setup_nav_menu_item().
+                $post_value['object_id'] = (string) $post_value['object_id'];
                 foreach ( $post_value as $key => $value ) {
-                        $this->assertEquals( $value, $updated_item->$key, "Key $key mismatch" );
+                        $this->assertSame( $value, $updated_item->$key, "Key $key mismatch" );
                 }
 
@@ -786 +776 @@
                 unset( $post_value['position'] );
 
-                /*
-                 * Keep assertEquals() because object_id is an integer in $post_value
-                 * but is returned as a string from post meta by wp_setup_nav_menu_item().
-                 */
+                // Cast object_id to string to match post meta values from wp_setup_nav_menu_item().
+                $post_value['object_id'] = (string) $post_value['object_id'];
                 foreach ( $post_value as $key => $value ) {
-                        $this->assertEquals( $value, $last_item->$key, "Mismatch for $key property." );
+                        $this->assertSame( $value, $last_item->$key, "Mismatch for $key property." );
                 }