Changeset 64314

Timestamp:

10/12/2026 01:26:22 PM (less than one hour ago)

Author:

lancewillett

Message:

Tests: Cover scheduled publication and the Scheduled posts view.

Add PHPUnit coverage for the registered publish_future_post callback: publish due posts, reschedule early calls, and ignore draft or missing posts.

Verify the Scheduled view link, filtered post IDs, and date-column labels for scheduled and past-due posts. Exercise real WordPress behavior without waiting for scheduled times.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/12668

Props csmcneill, lucatume.
Fixes #65772.

Location:

trunk/tests/phpunit/tests

Files:

• admin/wpPostsListTable.php (modified) (1 diff)
• cron.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/wpPostsListTable.php

@@ -409 +409 @@
 
         /**
+         * @ticket 65772
+         * @covers WP_Posts_List_Table::get_views
+         */
+        public function test_get_views_should_include_scheduled_posts_link() {
+                $global_names = array( 'avail_post_stati', 'locked_post_status', 'post_type_object' );
+                $backup       = array_intersect_key( $GLOBALS, array_flip( $global_names ) );
+                $future_date  = gmdate( 'Y-m-d H:i:s', time() + DAY_IN_SECONDS );
+                self::factory()->post->create(
+                        array(
+                                'post_status'   => 'future',
+                                'post_date'     => get_date_from_gmt( $future_date ),
+                                'post_date_gmt' => $future_date,
+                        )
+                );
+
+                try {
+                        $GLOBALS['locked_post_status'] = '';
+                        $GLOBALS['avail_post_stati']   = get_available_post_statuses( 'post' );
+                        $table                         = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => 'edit-post' ) );
+
+                        $views = $table->get_views();
+
+                        $this->assertArrayHasKey( 'future', $views );
+                        $this->assertSame(
+                                '<a href="edit.php?post_status=future&#038;post_type=post">Scheduled <span class="count">(1)</span></a>',
+                                $views['future']
+                        );
+                } finally {
+                        foreach ( $global_names as $name ) {
+                                if ( array_key_exists( $name, $backup ) ) {
+                                        $GLOBALS[ $name ] = $backup[ $name ];
+                                } else {
+                                        unset( $GLOBALS[ $name ] );
+                                }
+                        }
+                }
+        }
+
+        /**
+         * @ticket 65772
+         * @covers WP_Posts_List_Table::prepare_items
+         */
+        public function test_prepare_items_should_only_include_scheduled_posts_when_filtered() {
+                $global_names = array( 'mode', 'avail_post_stati', 'per_page', 'post_type_object' );
+                $backup       = array_intersect_key( $GLOBALS, array_flip( $global_names ) );
+                $future_date  = gmdate( 'Y-m-d H:i:s', time() + DAY_IN_SECONDS );
+                $scheduled_id = self::factory()->post->create(
+                        array(
+                                'post_status'   => 'future',
+                                'post_date'     => get_date_from_gmt( $future_date ),
+                                'post_date_gmt' => $future_date,
+                        )
+                );
+                self::factory()->post->create( array( 'post_status' => 'publish' ) );
+                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+
+                try {
+                        $_GET     = array(
+                                'post_type'   => 'post',
+                                'post_status' => 'future',
+                        );
+                        $_REQUEST = $_GET;
+                        $table    = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => 'edit-post' ) );
+
+                        $table->prepare_items();
+
+                        $post_ids = wp_list_pluck( $GLOBALS['wp_query']->posts, 'ID' );
+                        $this->assertSame( array( $scheduled_id ), $post_ids );
+                } finally {
+                        foreach ( $global_names as $name ) {
+                                if ( array_key_exists( $name, $backup ) ) {
+                                        $GLOBALS[ $name ] = $backup[ $name ];
+                                } else {
+                                        unset( $GLOBALS[ $name ] );
+                                }
+                        }
+                }
+        }
+
+        /**
+         * @ticket 65772
+         * @dataProvider data_scheduled_post_date_column_status
+         * @covers WP_Posts_List_Table::column_date
+         *
+         * @param int    $offset   Seconds from now to the scheduled date.
+         * @param string $expected Expected status markup.
+         */
+        public function test_column_date_should_show_scheduled_post_status( $offset, $expected ) {
+                $future_date = gmdate( 'Y-m-d H:i:s', time() + DAY_IN_SECONDS );
+                $post        = self::factory()->post->create_and_get(
+                        array(
+                                'post_status'   => 'future',
+                                'post_date'     => get_date_from_gmt( $future_date ),
+                                'post_date_gmt' => $future_date,
+                        )
+                );
+
+                // Model an overdue date without letting wp_update_post() publish the fixture.
+                $date                = gmdate( 'Y-m-d H:i:s', time() + $offset );
+                $post->post_date     = get_date_from_gmt( $date );
+                $post->post_date_gmt = $date;
+
+                ob_start();
+                try {
+                        $this->table->column_date( $post );
+                        $output = ob_get_contents();
+                } finally {
+                        ob_end_clean();
+                }
+
+                $this->assertStringStartsWith( $expected . '<br />', $output );
+        }
+
+        /**
+         * @return array[]
+         */
+        public function data_scheduled_post_date_column_status() {
+                return array(
+                        'future date'   => array( DAY_IN_SECONDS, 'Scheduled' ),
+                        'past due date' => array( -DAY_IN_SECONDS, '<strong class="error-message">Missed schedule</strong>' ),
+                );
+        }
+
+        /**
          * Renders the title column for a post in a given list view mode.
          *

trunk/tests/phpunit/tests/cron.php

@@ -29 +29 @@
                 _set_cron_array( array() );
                 parent::tear_down();
+        }
+
+        /**
+         * Tests that the scheduled publication hook publishes a post whose date is due.
+         *
+         * @ticket 65772
+         * @group post
+         * @covers ::check_and_publish_future_post
+         */
+        public function test_scheduled_post_should_publish_when_due() {
+                global $wpdb;
+
+                $future_date = gmdate( 'Y-m-d H:i:s', $this->plus_thirty_minutes );
+                $post_id     = self::factory()->post->create(
+                        array(
+                                'post_status'   => 'future',
+                                'post_date'     => get_date_from_gmt( $future_date ),
+                                'post_date_gmt' => $future_date,
+                        )
+                );
+                $event       = wp_get_scheduled_event( 'publish_future_post', array( $post_id ) );
+
+                $this->assertNotFalse( $event, 'Creating a future post should schedule publication.' );
+
+                // Make the post due without letting wp_update_post() publish it during setup.
+                $past_date = gmdate( 'Y-m-d H:i:s', time() - HOUR_IN_SECONDS );
+                $this->assertSame(
+                        1,
+                        $wpdb->update(
+                                $wpdb->posts,
+                                array(
+                                        'post_date'     => get_date_from_gmt( $past_date ),
+                                        'post_date_gmt' => $past_date,
+                                ),
+                                array( 'ID' => $post_id )
+                        )
+                );
+                clean_post_cache( $post_id );
+                $this->assertSame( 'future', get_post_status( $post_id ), 'Setup must not publish the post.' );
+
+                // Cron removes a single event before calling its hook.
+                $this->assertTrue( wp_unschedule_event( $event->timestamp, $event->hook, $event->args ) );
+
+                // Exercise the registered callback with the scheduled event's real arguments.
+                do_action_ref_array( $event->hook, $event->args );
+
+                clean_post_cache( $post_id );
+                $this->assertSame( 'publish', get_post_status( $post_id ) );
+                $this->assertFalse( wp_next_scheduled( 'publish_future_post', array( $post_id ) ) );
+        }
+
+        /**
+         * Tests that an early publication hook leaves the post scheduled for its date.
+         *
+         * @ticket 65772
+         * @group post
+         * @covers ::check_and_publish_future_post
+         */
+        public function test_scheduled_post_should_not_publish_before_due() {
+                $future_date = gmdate( 'Y-m-d H:i:s', $this->plus_thirty_minutes );
+                $post_id     = self::factory()->post->create(
+                        array(
+                                'post_status'   => 'future',
+                                'post_date'     => get_date_from_gmt( $future_date ),
+                                'post_date_gmt' => $future_date,
+                        )
+                );
+                $event       = wp_get_scheduled_event( 'publish_future_post', array( $post_id ) );
+
+                $this->assertNotFalse( $event );
+                $this->assertSame( 'future', get_post_status( $post_id ) );
+
+                // Cron removes a single event before calling its hook. An early call must reschedule it.
+                $this->assertTrue( wp_unschedule_event( $event->timestamp, $event->hook, $event->args ) );
+                $this->assertFalse( wp_next_scheduled( 'publish_future_post', array( $post_id ) ) );
+
+                do_action_ref_array( $event->hook, $event->args );
+
+                clean_post_cache( $post_id );
+                $this->assertSame( 'future', get_post_status( $post_id ) );
+                $this->assertSame( $this->plus_thirty_minutes, wp_next_scheduled( 'publish_future_post', array( $post_id ) ) );
+        }
+
+        /**
+         * @ticket 65772
+         * @group post
+         * @covers ::check_and_publish_future_post
+         */
+        public function test_draft_post_should_not_publish_when_scheduled_hook_fires() {
+                $post_id = self::factory()->post->create( array( 'post_status' => 'draft' ) );
+
+                do_action_ref_array( 'publish_future_post', array( $post_id ) );
+
+                clean_post_cache( $post_id );
+                $this->assertSame( 'draft', get_post_status( $post_id ) );
+        }
+
+        /**
+         * @ticket 65772
+         * @group post
+         * @covers ::check_and_publish_future_post
+         */
+        public function test_missing_post_should_be_ignored_when_scheduled_hook_fires() {
+                do_action_ref_array( 'publish_future_post', array( PHP_INT_MAX ) );
+
+                $this->assertFalse( wp_next_scheduled( 'publish_future_post', array( PHP_INT_MAX ) ) );
         }