Changeset 64322

Timestamp:

10/13/2026 05:49:42 AM (11 days ago)

Author:

isabel_brison

Message:

Editor: unset incompatible dimensions styles in viewport states.

Re-adds a missed line from a previous Gutenberg sync to enable unsetting height and min-height when aspect ratio is set for a viewport state, and vice versa.

Props isabel_brison, westonruter, marian1, abditsori.
Fixes #66275.

Location:

trunk

Files:

• src/wp-includes/block-supports/states.php (modified) (2 diffs)
• tests/phpunit/tests/block-supports/states.php (modified) (1 diff)

trunk/src/wp-includes/block-supports/states.php

@@ -365 +365 @@
  *
  * @since 7.1.0
+ * @since 7.2.0 Added fallback dimension styles.
  *
  * @param array       $css_rules   Style rules.
@@ -376 +377 @@
                 return;
         }
+
+        $style = wp_get_state_style_with_fallback_dimension_styles( $style );
 
         $compiled     = wp_style_engine_get_styles(

trunk/tests/phpunit/tests/block-supports/states.php

@@ -882 +882 @@
 
                 $this->assertSame( $expected, $actual );
+        }
+
+        /**
+         * Tests that rendered state CSS includes fallback dimension declarations.
+         *
+         * @covers ::wp_render_block_states_support
+         * @covers ::wp_add_block_state_style_rule
+         *
+         * @ticket 66275
+         */
+        public function test_responsive_height_generates_aspect_ratio_unset_in_stylesheet() {
+                $this->ensure_block_registered( 'test/responsive-root-state' );
+
+                $block = array(
+                        'blockName' => 'test/responsive-root-state',
+                        'attrs'     => array(
+                                'style' => array(
+                                        '@mobile' => array(
+                                                'dimensions' => array( 'minHeight' => '300px' ),
+                                        ),
+                                ),
+                        ),
+                );
+
+                $actual    = wp_render_block_states_support( '<div class="wp-block-test">Hello</div>', $block );
+                $processor = new WP_HTML_Tag_Processor( $actual );
+                $this->assertTrue( $processor->next_tag() );
+
+                $state_class = null;
+                foreach ( $processor->class_list() as $class_name ) {
+                        if ( str_starts_with( $class_name, 'wp-states-' ) ) {
+                                $state_class = $class_name;
+                                break;
+                        }
+                }
+                $this->assertIsString( $state_class, 'Expected a wp-states-* class on the first tag.' );
+
+                $actual_stylesheet = wp_style_engine_get_stylesheet_from_context( 'block-supports', array( 'prettify' => false ) );
+
+                $this->assertStringContainsString(
+                        "@media (width <= 480px){.{$state_class}{",
+                        $actual_stylesheet
+                );
+                $this->assertStringContainsString( 'min-height:300px', $actual_stylesheet );
+                $this->assertStringContainsString( 'aspect-ratio:unset', $actual_stylesheet );
         }