Changeset 64367

Timestamp:

10/15/2026 08:59:04 PM (11 hours ago)

Author:

lancewillett

Message:

Tests: Reduce setup overhead in REST comments tests.

Remove the unused controller instance and two unused post creations from WP_Test_REST_Comments_Controller. Reuse existing class fixtures in four permission and validation tests that reject requests before creating database records.

Preserve the existing assertions while avoiding unnecessary fixture setup.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14258

Props sainathpoojary.
See #66074.

File:

• trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php (modified) (8 diffs)

trunk/tests/phpunit/tests/rest-api/rest-comments-controller.php

@@ -31 +31 @@
         protected static $num_notes      = 10;
 
-        protected $endpoint;
-
         public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
                 add_role(
@@ -170 +168 @@
         public function set_up() {
                 parent::set_up();
-                $this->endpoint = new WP_REST_Comments_Controller();
                 wp_create_initial_comment_meta();
 
@@ -648 +645 @@
                 wp_set_current_user( 0 );
 
-                $post_id = self::factory()->post->create( array( 'post_status' => 'private' ) );
-
                 $request = new WP_REST_Request( $method, '/wp/v2/comments' );
-                $request->set_param( 'post', $post_id );
+                $request->set_param( 'post', self::$private_id );
                 $response = rest_get_server()->dispatch( $request );
                 $this->assertErrorResponse( 'rest_cannot_read_post', $response, 401 );
@@ -1682 +1677 @@
          */
         public function test_create_comment_with_invalid_type() {
-                $post_id = self::factory()->post->create();
-
-                wp_set_current_user( self::$admin_id );
-
-                $params = array(
-                        'post'         => $post_id,
+                wp_set_current_user( self::$admin_id );
+
+                $params = array(
+                        'post'         => self::$post_id,
                         'author'       => self::$admin_id,
                         'author_name'  => 'Comic Book Guy',
@@ -1706 +1699 @@
 
         public function test_create_comment_invalid_email() {
-                $post_id = self::factory()->post->create();
-
-                wp_set_current_user( self::$admin_id );
-
-                $params = array(
-                        'post'         => $post_id,
+                wp_set_current_user( self::$admin_id );
+
+                $params = array(
+                        'post'         => self::$post_id,
                         'author'       => self::$admin_id,
                         'author_name'  => 'Comic Book Guy',
@@ -2522 +2513 @@
 
         public function test_update_item_no_content() {
-                $post_id = self::factory()->post->create();
-
                 wp_set_current_user( self::$admin_id );
 
@@ -2544 +2533 @@
          */
         public function test_update_item_no_content_allow_empty_comment_filter() {
-                $post_id = self::factory()->post->create();
-
                 wp_set_current_user( self::$admin_id );
 
@@ -3878 +3865 @@
         public function test_cannot_create_with_non_valid_comment_type() {
                 wp_set_current_user( self::$admin_id );
-                $post_id = self::factory()->post->create();
-
-                $params = array(
-                        'post'         => $post_id,
+
+                $params = array(
+                        'post'         => self::$post_id,
                         'author_name'  => 'Ishmael',
                         'author_email' => 'herman-melville@earthlink.net',