Changeset 64392

Timestamp:

10/16/2026 03:46:38 PM (13 hours ago)

Author:

lancewillett

Message:

Tests: Separate theme feature validation tests.

Move test_register_theme_support_validation() and its provider into a separate WP_UnitTestCase class to avoid unnecessary theme-directory and cache setup. Preserve all eight datasets, assertions, and expected errors.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14306

Props sainathpoojary.
See #66074.

Location:

trunk/tests/phpunit/tests

Files:

• theme.php (modified) (1 diff)
• theme/registerThemeFeature.php (added)

trunk/tests/phpunit/tests/theme.php

@@ -830 +830 @@
 
         /**
-         * @ticket 49406
-         *
-         * @dataProvider data_register_theme_support_validation
-         *
-         * @param string $error_code The error code expected.
-         * @param array  $args       The args to register.
-         */
-        public function test_register_theme_support_validation( $error_code, $args ) {
-                $registered = register_theme_feature( 'test-feature', $args );
-
-                $this->assertWPError( $registered );
-                $this->assertSame( $error_code, $registered->get_error_code() );
-        }
-
-        public function data_register_theme_support_validation() {
-                return array(
-                        array(
-                                'invalid_type',
-                                array(
-                                        'type' => 'float',
-                                ),
-                        ),
-                        array(
-                                'invalid_type',
-                                array(
-                                        'type' => array( 'string' ),
-                                ),
-                        ),
-                        array(
-                                'variadic_must_be_array',
-                                array(
-                                        'variadic' => true,
-                                ),
-                        ),
-                        array(
-                                'missing_schema',
-                                array(
-                                        'type'         => 'object',
-                                        'show_in_rest' => true,
-                                ),
-                        ),
-                        array(
-                                'missing_schema',
-                                array(
-                                        'type'         => 'array',
-                                        'show_in_rest' => true,
-                                ),
-                        ),
-                        array(
-                                'missing_schema_items',
-                                array(
-                                        'type'         => 'array',
-                                        'show_in_rest' => array(
-                                                'schema' => array(
-                                                        'type' => 'array',
-                                                ),
-                                        ),
-                                ),
-                        ),
-                        array(
-                                'missing_schema_properties',
-                                array(
-                                        'type'         => 'object',
-                                        'show_in_rest' => array(
-                                                'schema' => array(
-                                                        'type' => 'object',
-                                                ),
-                                        ),
-                                ),
-                        ),
-                        array(
-                                'invalid_rest_prepare_callback',
-                                array(
-                                        'show_in_rest' => array(
-                                                'prepare_callback' => 'this is not a valid function',
-                                        ),
-                                ),
-                        ),
-                );
-        }
-
-
-        /**
          * Tests that block themes support a feature by default.
          *