Changeset 64434

Timestamp:

10/16/2026 10:48:16 PM (28 hours ago)

Author:

SergeyBiryukov

Message:

Database: Correct uppercasing the SQL mode values in wpdb::set_sql_mode().

wpdb::set_sql_mode() aimed to convert lowercased values to uppercase before comparing them with the incompatible_sql_modes filter results, but the case conversion was erroneously performed on numeric keys of the modes array rather than the string values. This commit ensures the array values are converted as expected.

Follow-up to r27072.

Props DavidAnderson, SergeyBiryukov.
Fixes #66326.

Location:

trunk

Files:

• src/wp-includes/class-wpdb.php (modified) (1 diff)
• tests/phpunit/tests/db.php (modified) (2 diffs)

trunk/src/wp-includes/class-wpdb.php

@@ -966 +966 @@
                 }
 
-                $modes = array_change_key_case( $modes, CASE_UPPER );
+                $modes = array_map( 'strtoupper', $modes );
 
                 /**

trunk/tests/phpunit/tests/db.php

@@ -294 +294 @@
 
         /**
-         * Test that SQL modes are set correctly
+         * Test that SQL modes are set correctly.
          *
          * @ticket 26847
@@ -309 +309 @@
                 $check_new_modes = $wpdb->get_var( 'SELECT @@SESSION.sql_mode;' );
                 $this->assertSameSets( $new_modes, explode( ',', $check_new_modes ) );
+
+                $wpdb->set_sql_mode( empty( $current_modes ) ? array() : explode( ',', $current_modes ) );
+        }
+
+        /**
+         * Test that SQL modes are uppercased correctly.
+         *
+         * @ticket 66326
+         */
+        public function test_set_sql_mode_corrects_lowercase() {
+                global $wpdb;
+
+                $current_modes = $wpdb->get_var( 'SELECT @@SESSION.sql_mode;' );
+
+                $new_modes = array( 'ignore_space', 'no_auto_value_on_zero' );
+
+                $wpdb->set_sql_mode( $new_modes );
+
+                $check_new_modes = $wpdb->get_var( 'SELECT @@SESSION.sql_mode;' );
+                $this->assertSameSets( array_map( 'strtoupper', $new_modes ), explode( ',', $check_new_modes ) );
 
                 $wpdb->set_sql_mode( empty( $current_modes ) ? array() : explode( ',', $current_modes ) );