Changeset 64458

Timestamp:

10/17/2026 11:21:34 PM (4 weeks ago)

Author:

SergeyBiryukov

Message:

Database: Avoid a fatal error in wpdb::load_col_info() if the result is not set.

This resolves an error if mysqli_num_fields() is called before a successful SELECT-type query is performed:

mysqli_num_fields(): Argument #1 ($result) must be of type mysqli_result, false given

Developed in ​https://github.com/WordPress/wordpress-develop/pull/13099.

Follow-up to r21472.

Props joehorntw, akshat2802, mukesh27, rejaulalomkhan, SergeyBiryukov.
Fixes #64130.

Location:

trunk

Files:

• src/wp-includes/class-wpdb.php (modified) (1 diff)
• tests/phpunit/tests/db.php (modified) (1 diff)

trunk/src/wp-includes/class-wpdb.php

@@ -3952 +3952 @@
          */
         protected function load_col_info() {
-                if ( $this->col_info ) {
+                if ( $this->col_info || ! $this->result instanceof mysqli_result ) {
                         return;
                 }

trunk/tests/phpunit/tests/db.php

@@ -584 +584 @@
                 $this->assertSame( array( $wpdb->users ), $wpdb->get_col_info( 'table' ) );
                 $this->assertSame( $wpdb->users, $wpdb->get_col_info( 'table', 0 ) );
+        }
+
+        /**
+         * @ticket 64130
+         *
+         * @covers wpdb::get_col_info
+         *
+         * @dataProvider data_get_col_info_without_result_set
+         *
+         * @param string $query Query that does not produce a result set.
+         */
+        public function test_get_col_info_without_result_set( $query ) {
+                global $wpdb;
+
+                $suppress = $wpdb->suppress_errors( true );
+                // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
+                $wpdb->query( sprintf( $query, $wpdb->options ) );
+                $wpdb->suppress_errors( $suppress );
+
+                $this->assertNull( $wpdb->get_col_info(), 'get_col_info() should return null.' );
+                $this->assertNull( $wpdb->col_info, 'The col_info property should be null.' );
+        }
+
+        /**
+         * Data provider.
+         *
+         * @return array<string, string[]>
+         */
+        public static function data_get_col_info_without_result_set() {
+                return array(
+                        'failed query' => array( 'SELECT ID FROM table_that_does_not_exist' ),
+                        'update query' => array( "UPDATE %s SET option_value = option_value WHERE option_name = 'blogname'" ),
+                        'set query'    => array( 'SET @wp_test_64130 = 1' ),
+                );
         }