Changeset 64484

Timestamp:

10/18/2026 12:24:57 AM (7 hours ago)

Author:

lancewillett

Message:

Tests: Reuse existing fixtures in REST user tests.

Reuse the author and subscriber fixtures in read-only and rejected-request tests in WP_Test_REST_Users_Controller, avoiding 13 user creations per class run.

Preserve the requests, assertions, and include-query ordering checks. Keep fresh users for successful updates, deletions, and identity-specific scenarios, and retain per-test post and page fixtures.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14339

Props abcd95.
See #66074.

File:

• trunk/tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (10 diffs)

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -657 +657 @@
                 wp_set_current_user( self::$user );
 
-                $id1 = self::factory()->user->create();
-                $id2 = self::factory()->user->create();
+                $id1 = self::$author;
+                $id2 = self::$subscriber;
 
                 $request = new WP_REST_Request( 'GET', '/wp/v2/users' );
@@ -692 +692 @@
                 wp_set_current_user( self::$user );
 
-                $id1 = self::factory()->user->create();
-                $id2 = self::factory()->user->create();
+                $id1 = self::$subscriber;
+                $id2 = self::$author;
 
                 $request = new WP_REST_Request( 'GET', '/wp/v2/users' );
@@ -1090 +1090 @@
 
         public function test_get_item() {
-                $user_id = self::factory()->user->create();
+                $user_id = self::$subscriber;
 
                 wp_set_current_user( self::$user );
@@ -1243 +1243 @@
 
         public function test_get_item_published_author_post() {
-                $author_id = self::factory()->user->create(
-                        array(
-                                'role' => 'author',
-                        )
-                );
+                $author_id = self::$author;
 
                 $post_id = self::factory()->post->create(
@@ -1263 +1259 @@
 
         public function test_get_item_published_author_pages() {
-                $author_id = self::factory()->user->create(
-                        array(
-                                'role' => 'author',
-                        )
-                );
+                $author_id = self::$author;
 
                 wp_set_current_user( 0 );
@@ -1287 +1279 @@
 
         public function test_get_user_with_edit_context() {
-                $user_id = self::factory()->user->create();
+                $user_id = self::$subscriber;
 
                 $this->allow_user_to_manage_multisite();
@@ -1298 +1290 @@
 
         public function test_get_item_published_author_wrong_context() {
-                $author_id = self::factory()->user->create(
-                        array(
-                                'role' => 'author',
-                        )
-                );
+                $author_id = self::$author;
 
                 $post_id = self::factory()->post->create(
@@ -2184 +2172 @@
          */
         public function test_update_item_only_roles_as_editor() {
-                $user_id = self::factory()->user->create(
-                        array(
-                                'role' => 'author',
-                        )
-                );
+                $user_id = self::$author;
 
                 wp_set_current_user( self::$editor );
@@ -2596 +2580 @@
 
         public function test_delete_user_without_permission() {
-                $user_id = self::factory()->user->create();
+                $user_id = self::$subscriber;
 
                 $this->allow_user_to_manage_multisite();
@@ -3317 +3301 @@
          */
         public function test_head_request_with_specified_fields_returns_success_response( $path ) {
-                $user_id = self::factory()->user->create();
+                $user_id = self::$subscriber;
                 wp_set_current_user( self::$user );