Changeset 64694

Timestamp:

10/24/2026 10:55:37 PM (7 hours ago)

Author:

SergeyBiryukov

Message:

Code Quality: Remove a redundant is_wp_error() check after uploading a plugin or theme.

After a plugin or theme is installed from an uploaded ZIP file in wp-admin/update.php, the upload is cleaned up when $result || is_wp_error( $result ). A WP_Error is an object and therefore always truthy, so the first operand already covers it and the is_wp_error() call can never return true. PHPStan reports this as function.impossibleType.

The condition is reduced to if ( $result ), which behaves identically: a failed installation still cleans up the upload, and only false, which WP_Upgrader::run() returns when filesystem credentials are requested, keeps the upload so it is still there once the credentials are entered.

This empties the function.impossibleType baseline, so the file and its entry in phpstan.neon.dist are removed.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/14778.

Props Soean.
See #65817.

Location:

trunk

Files:

• phpstan.neon.dist (modified) (1 diff)
• src/wp-admin/update.php (modified) (2 diffs)
• tests/phpstan/baselines/function.impossibleType.neon (deleted)

trunk/phpstan.neon.dist

@@ -38 +38 @@
         - tests/phpstan/baselines/empty.variable.neon
         - tests/phpstan/baselines/function.alreadyNarrowedType.neon
-        - tests/phpstan/baselines/function.impossibleType.neon
         - tests/phpstan/baselines/function.resultUnused.neon
         - tests/phpstan/baselines/identical.alwaysFalse.neon

trunk/src/wp-admin/update.php

@@ -180 +180 @@
                 $result   = $upgrader->install( $file_upload->package, array( 'overwrite_package' => $overwrite ) );
 
-                if ( $result || is_wp_error( $result ) ) {
+                if ( $result ) {
                         $file_upload->cleanup();
                 }
@@ -332 +332 @@
                 $result   = $upgrader->install( $file_upload->package, array( 'overwrite_package' => $overwrite ) );
 
-                if ( $result || is_wp_error( $result ) ) {
+                if ( $result ) {
                         $file_upload->cleanup();
                 }