Changeset 64744

Timestamp:

10/26/2026 09:25:36 PM (10 hours ago)

Author:

lancewillett

Message:

Tests: Make URL, routing, hook and shortcode data providers static.

Declare 20 data providers in the actions, admin bar, canonical, filters, rewrite, shortcode and URL tests as public static for compatibility with newer PHPUnit versions. Preserve their datasets and assertions.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14706, ​https://github.com/WordPress/wordpress-develop/pull/14723, ​https://github.com/WordPress/wordpress-develop/pull/14724, ​https://github.com/WordPress/wordpress-develop/pull/14790, ​https://github.com/WordPress/wordpress-develop/pull/14792, ​https://github.com/WordPress/wordpress-develop/pull/14793, ​https://github.com/WordPress/wordpress-develop/pull/14803

Props devmuhib, shailu25, mukesh27, huzaifaalmesbah.
See #66211.

Location:

trunk/tests/phpunit/tests

Files:

• actions.php (modified) (2 diffs)
• adminbar.php (modified) (2 diffs)
• canonical.php (modified) (4 diffs)
• filters.php (modified) (2 diffs)
• rewrite.php (modified) (1 diff)
• shortcode.php (modified) (6 diffs)
• url.php (modified) (3 diffs)

trunk/tests/phpunit/tests/actions.php

@@ -287 +287 @@
          * @return array[]
          */
-        public function data_priority_callback_order_with_integers() {
+        public static function data_priority_callback_order_with_integers() {
                 return array(
                         'int DESC' => array(
@@ -305 +305 @@
          * @return array[]
          */
-        public function data_priority_callback_order_with_unhappy_path_nonintegers() {
+        public static function data_priority_callback_order_with_unhappy_path_nonintegers() {
                 return array(
                         // Numbers as strings and floats.

trunk/tests/phpunit/tests/adminbar.php

@@ -277 +277 @@
          * }
          */
-        public function data_admin_bar_nodes_with_tabindex_meta() {
+        public static function data_admin_bar_nodes_with_tabindex_meta() {
                 return array(
                         array(
@@ -805 +805 @@
          * }
          */
-        public function data_my_sites_network_menu_items() {
+        public static function data_my_sites_network_menu_items() {
                 return array(
                         array( 'my-sites-super-admin', 'manage_network' ),

trunk/tests/phpunit/tests/canonical.php

@@ -69 +69 @@
         }
 
-        public function data_canonical() {
+        public static function data_canonical() {
                 /*
                  * Data format:
@@ -346 +346 @@
          * }
          */
-        public function data_redirect_guess_404_permalink_with_custom_statuses() {
+        public static function data_redirect_guess_404_permalink_with_custom_statuses() {
                 return array(
                         'public status'                      => array(
@@ -396 +396 @@
          * @return array[]
          */
-        public function data_redirect_guess_404_permalink_post_types() {
+        public static function data_redirect_guess_404_permalink_post_types() {
                 return array(
                         'single string formatted post type'    => array(
@@ -674 +674 @@
          * @return array[]
          */
-        public function data_canonical_attachment_page_redirect_with_option_disabled() {
+        public static function data_canonical_attachment_page_redirect_with_option_disabled() {
                 return array(
                         'logged out user, no parent'      => array(

trunk/tests/phpunit/tests/filters.php

@@ -182 +182 @@
          * @return array[]
          */
-        public function data_priority_callback_order_with_integers() {
+        public static function data_priority_callback_order_with_integers() {
                 return array(
                         'int DESC' => array(
@@ -200 +200 @@
          * @return array[]
          */
-        public function data_priority_callback_order_with_unhappy_path_nonintegers() {
+        public static function data_priority_callback_order_with_unhappy_path_nonintegers() {
                 return array(
                         // Numbers as strings and floats.

trunk/tests/phpunit/tests/rewrite.php

@@ -295 +295 @@
          * @return array[]
          */
-        public function data_url_to_postid_host_matching() {
+        public static function data_url_to_postid_host_matching() {
                 return array(
                         'the site host'              => array( 'example.com', true ),

trunk/tests/phpunit/tests/shortcode.php

@@ -429 +429 @@
         }
 
-        public function data_strip_shortcodes() {
+        public static function data_strip_shortcodes() {
                 return array(
                         array( 'before', 'before[gallery]' ),
@@ -548 +548 @@
         }
 
-        public function data_escaping() {
+        public static function data_escaping() {
                 return array(
                         array(
@@ -626 +626 @@
         }
 
-        public function data_escaping2() {
+        public static function data_escaping2() {
                 return array(
                         array(
@@ -701 +701 @@
         }
 
-        public function data_registration_bad() {
+        public static function data_registration_bad() {
                 return array(
                         array(
@@ -734 +734 @@
         }
 
-        public function data_registration_good() {
+        public static function data_registration_good() {
                 return array(
                         array(
@@ -762 +762 @@
         }
 
-        public function data_whole_posts() {
+        public static function data_whole_posts() {
                 require_once DIR_TESTDATA . '/formatting/whole-posts.php';
                 return data_whole_posts();

trunk/tests/phpunit/tests/url.php

@@ -36 +36 @@
         }
 
-        public function data_is_ssl() {
+        public static function data_is_ssl() {
                 return array(
                         array(
@@ -103 +103 @@
         }
 
-        public function data_admin_urls() {
+        public static function data_admin_urls() {
                 return array(
                         array(
@@ -173 +173 @@
         }
 
-        public function data_home_urls() {
+        public static function data_home_urls() {
                 return array(
                         array(