Changeset 64747

Timestamp:

10/26/2026 09:49:27 PM (4 days ago)

Author:

lancewillett

Message:

Tests: Resolve gallery attachment IDs after fixture setup.

Resolve the gallery shortcode's attachment ID during test execution instead of in the data provider, which runs before fixture setup. Add an unrelated attachment and assert that the response includes only the intended caption.

Preserve the existing success and rejection expectations for all three shortcode cases.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14832

Props benitoalba.
See #66211.

File:

• trunk/tests/phpunit/tests/ajax/wpAjaxParseMediaShortcode.php (modified) (4 diffs)

trunk/tests/phpunit/tests/ajax/wpAjaxParseMediaShortcode.php

@@ -34 +34 @@
                         )
                 );
+                $factory->attachment->create_object(
+                        get_temp_dir() . 'canola.jpg',
+                        0,
+                        array(
+                                'post_mime_type' => 'image/jpeg',
+                                'post_excerpt'   => 'An unrelated caption',
+                        )
+                );
         }
         /**
@@ -40 +48 @@
         public function test_parse_shortcode( array $payload, $expected ) {
                 add_shortcode( 'test', array( $this, 'shortcode_test' ) );
+                $payload['shortcode'] = sprintf( $payload['shortcode'], self::$media_id );
 
                 $_POST = array_merge(
@@ -61 +70 @@
                 }
                 $this->assertSame( $expected['success'], $response['success'] );
+                if ( $expected['success'] ) {
+                        $this->assertStringContainsString( 'A sample caption', $body );
+                        $this->assertStringNotContainsString( 'An unrelated caption', $body );
+                }
         }
 
@@ -70 +83 @@
                 return array(
                         'gallery_shortcode_is_allowed'         => array(
-                                'payload'  => array( 'shortcode' => '[gallery ids=" ' . self::$media_id . '"]' ),
+                                'payload'  => array( 'shortcode' => '[gallery ids="%d"]' ),
                                 'expected' => array( 'success' => true ),
                         ),
                         'gallery_and_custom_test_shortcode_is_not_allowed' => array(
-                                'payload'  => array( 'shortcode' => '[gallery ids=" ' . self::$media_id . '"] [test]' ),
+                                'payload'  => array( 'shortcode' => '[gallery ids="%d"] [test]' ),
                                 'expected' => array( 'success' => false ),
                         ),