Changeset 64804

Timestamp:

10/27/2026 05:48:06 PM (3 days ago)

Author:

lancewillett

Message:

Tests: Use strict inequality in Customizer tests.

Use assertNotSame() for scalar and array comparisons in Customizer tests, including menu item counts, changeset data, and sidebar parameters.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14975

Props shailu25.
See #64895.

Location:

trunk/tests/phpunit/tests/customize

Files:

• manager.php (modified) (8 diffs)
• nav-menu-item-setting.php (modified) (4 diffs)
• setting.php (modified) (1 diff)
• widgets.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/manager.php

@@ -422 +422 @@
                 $title        = 'Hello World';
                 $wp_customize->set_post_value( 'blogname', $title );
-                $this->assertNotEquals( $title, get_option( 'blogname' ) );
+                $this->assertNotSame( $title, get_option( 'blogname' ) );
                 $wp_customize->wp_loaded();
                 $this->assertFalse( $wp_customize->is_preview() );
@@ -451 +451 @@
 
                 // Verify that the found post ID was cached under the given UUID, not the manager's UUID.
-                $this->assertNotEquals( $post_id, $wp_customize->find_changeset_post_id( $wp_customize->changeset_uuid() ) );
+                $this->assertNotSame( $post_id, $wp_customize->find_changeset_post_id( $wp_customize->changeset_uuid() ) );
         }
 
@@ -535 +535 @@
                 );
                 $this->assertTrue( $wp_customize->autosaved() );
-                $this->assertNotEquals( $data, $wp_customize->changeset_data() );
+                $this->assertNotSame( $data, $wp_customize->changeset_data() );
                 $this->assertSame(
                         array_merge(
@@ -801 +801 @@
                 $this->assertSame( $previous_blogname, $changeset_data['blogname']['value'] );
                 $this->assertArrayNotHasKey( 'starter_content', $changeset_data['blogname'] );
-                $this->assertNotEquals( $previous_blogdescription, $changeset_data['blogdescription']['value'] );
+                $this->assertNotSame( $previous_blogdescription, $changeset_data['blogdescription']['value'] );
                 $this->assertArrayHasKey( 'starter_content', $changeset_data['blogdescription'] );
 
@@ -813 +813 @@
                 $this->assertSame( 'auto-draft', get_post( $posts_by_name['about'] )->post_status );
                 $this->assertSame( 'auto-draft', get_post( $posts_by_name['waffles'] )->post_status );
-                $this->assertNotEquals( $changeset_data['blogname']['value'], get_option( 'blogname' ) );
+                $this->assertNotSame( $changeset_data['blogname']['value'], get_option( 'blogname' ) );
                 $r = $wp_customize->save_changeset_post( array( 'status' => 'publish' ) );
                 $this->assertIsArray( $r );
@@ -1088 +1088 @@
                 $this->assertSame( 'auto-draft', get_post( $post_id )->post_status );
                 $this->assertSame( $date, get_post( $post_id )->post_date_gmt );
-                $this->assertNotEquals( 'Changeset Title', get_option( 'blogname' ) );
+                $this->assertNotSame( 'Changeset Title', get_option( 'blogname' ) );
                 $this->assertArrayHasKey( 'setting_validities', $r );
 
@@ -1170 +1170 @@
                 $this->assertWPError( $r['setting_validities']['bar_unknown'] );
                 $saved_data = json_decode( get_post( $post_id )->post_content, true );
-                $this->assertNotEquals( $previous_saved_data, $saved_data );
+                $this->assertNotSame( $previous_saved_data, $saved_data );
                 $this->assertSame( 'Non-Transactional \o/ <script>unsanitized</script>', $saved_data['blogname']['value'] );
 
@@ -1722 +1722 @@
 
                 $post = get_post( $changeset_post_id );
-                $this->assertNotEquals( $post->post_date, $original_post_date );
+                $this->assertNotSame( $post->post_date, $original_post_date );
         }
 

trunk/tests/phpunit/tests/customize/nav-menu-item-setting.php

@@ -457 +457 @@
                 $setting->preview();
                 $preview_items = wp_get_nav_menu_items( $menu_id );
-                $this->assertNotEquals( count( $current_items ), count( $preview_items ) );
+                $this->assertNotSame( count( $current_items ), count( $preview_items ) );
 
                 $last_item = array_pop( $preview_items );
@@ -506 +506 @@
                 $setting->preview();
                 $preview_items = wp_get_nav_menu_items( $menu_id );
-                $this->assertNotEquals( count( $current_items ), count( $preview_items ) );
+                $this->assertNotSame( count( $current_items ), count( $preview_items ) );
                 $this->assertContains( $delete_item_id, wp_list_pluck( $current_items, 'db_id' ) );
         }
@@ -767 +767 @@
                 $setting->save();
                 $preview_items = wp_get_nav_menu_items( $menu_id );
-                $this->assertNotEquals( count( $current_items ), count( $preview_items ) );
+                $this->assertNotSame( count( $current_items ), count( $preview_items ) );
 
                 $last_item = array_pop( $preview_items );
@@ -833 +833 @@
                 $setting->save();
                 $preview_items = wp_get_nav_menu_items( $menu_id );
-                $this->assertNotEquals( count( $current_items ), count( $preview_items ) );
+                $this->assertNotSame( count( $current_items ), count( $preview_items ) );
                 $this->assertContains( $delete_item_id, wp_list_pluck( $current_items, 'db_id' ) );
 

trunk/tests/phpunit/tests/customize/setting.php

@@ -602 +602 @@
                 switch_to_blog( $blog_id );
                 $this->assertFalse( $setting->is_current_blog_previewed() );
-                $this->assertNotEquals( $post_value, $setting->value() );
-                $this->assertNotEquals( $post_value, get_option( $name ) );
+                $this->assertNotSame( $post_value, $setting->value() );
+                $this->assertNotSame( $post_value, get_option( $name ) );
                 restore_current_blog();
         }

trunk/tests/phpunit/tests/customize/widgets.php

@@ -834 +834 @@
 
                 $filtered_params = $this->manager->widgets->filter_dynamic_sidebar_params( $params );
-                $this->assertNotEquals( $params, $filtered_params );
+                $this->assertNotSame( $params, $filtered_params );
                 ob_start();
                 do_action( 'dynamic_sidebar_after', 'foo' );