Changeset 64808

Timestamp:

10/27/2026 05:53:36 PM (42 hours ago)

Author:

lancewillett

Message:

Tests: Use strict inequality in top-level test files.

Use assertNotSame() for scalar and array comparisons in database, post count, rewrite, and widget tests.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/14982

Props shailu25.
See #64895.

Location:

trunk/tests/phpunit/tests

Files:

• db.php (modified) (2 diffs)
• post.php (modified) (2 diffs)
• rewrite.php (modified) (1 diff)
• widgets.php (modified) (1 diff)

trunk/tests/phpunit/tests/db.php

@@ -260 +260 @@
                 $wpdb->col_meta = $new_meta;
 
-                $this->assertNotEquals( $col_meta, $new_meta );
+                $this->assertNotSame( $col_meta, $new_meta );
                 $this->assertSame( $col_meta, $wpdb->col_meta );
         }
@@ -572 +572 @@
                 $stop = $wpdb->timer_stop();
 
-                $this->assertNotEquals( $wpdb->time_start, $stop );
+                $this->assertNotSame( $wpdb->time_start, $stop );
                 $this->assertGreaterThan( $stop, $wpdb->time_start );
         }

trunk/tests/phpunit/tests/post.php

@@ -280 +280 @@
                 $this->assertSame( '1', $after_draft_counts->draft );
                 $this->assertSame( '2', $after_draft_counts->publish );
-                $this->assertNotEquals( $initial_counts->publish, $after_draft_counts->publish );
+                $this->assertNotSame( $initial_counts->publish, $after_draft_counts->publish );
         }
 
@@ -301 +301 @@
                 $this->assertSame( '1', $after_trash_counts->trash );
                 $this->assertSame( '2', $after_trash_counts->publish );
-                $this->assertNotEquals( $initial_counts->publish, $after_trash_counts->publish );
+                $this->assertNotSame( $initial_counts->publish, $after_trash_counts->publish );
         }
 

trunk/tests/phpunit/tests/rewrite.php

@@ -372 +372 @@
 
                 $this->go_to( $not_a_home_url . 'page' );
-                $this->assertNotEquals(
+                $this->assertNotSame(
                         array(
                                 'page'     => '',

trunk/tests/phpunit/tests/widgets.php

@@ -1253 +1253 @@
 
                 // Sidebar_widgets option was not updated.
-                $this->assertNotEquals( $sidebars_widgets, wp_get_sidebars_widgets() );
+                $this->assertNotSame( $sidebars_widgets, wp_get_sidebars_widgets() );
         }