Changeset 65106

Timestamp:

10/30/2026 10:12:24 PM (8 hours ago)

Author:

lancewillett

Message:

Tests: Cover empty objects in REST media responses.

Verify empty media_details.sizes and missing attachment metadata are returned as objects that encode to {}, preserving the REST response schema.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/13685

Props therssoftware, huzaifaalmesbah.
See #65251.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -1193 +1193 @@
                 $this->assertIsArray( $data['media_details']['sizes'], 'Could not retrieve the sizes data.' );
                 $this->assertArrayNotHasKey( 'source_url', $data['media_details']['sizes']['rest-api-test'] );
+        }
+
+        /**
+         * @ticket 65251
+         */
+        public function test_get_item_sizes_empty_sizes_is_object() {
+                $attachment_id = self::factory()->attachment->create_object(
+                        self::$test_file,
+                        0,
+                        array(
+                                'post_mime_type' => 'image/jpeg',
+                                'post_excerpt'   => 'A sample caption',
+                        ),
+                        self::$test_file
+                );
+
+                wp_update_attachment_metadata(
+                        $attachment_id,
+                        array(
+                                'width'      => 50,
+                                'height'     => 50,
+                                'file'       => 'canola.jpg',
+                                'sizes'      => array(),
+                                'image_meta' => array(),
+                        )
+                );
+
+                $request  = new WP_REST_Request( 'GET', '/wp/v2/media/' . $attachment_id );
+                $response = rest_get_server()->dispatch( $request );
+                $data     = $response->get_data();
+
+                $this->assertInstanceOf( 'stdClass', $data['media_details']['sizes'], 'Sizes should be an empty object (stdClass) when empty.' );
+                $this->assertSame( '{}', wp_json_encode( $data['media_details']['sizes'] ), 'Sizes must JSON-encode as an empty object.' );
+        }
+
+        /**
+         * @ticket 65251
+         */
+        public function test_get_item_empty_media_details_is_object() {
+                $attachment_id = self::factory()->attachment->create_object(
+                        self::$test_file,
+                        0,
+                        array(
+                                'post_mime_type' => 'image/jpeg',
+                                'post_excerpt'   => 'A sample caption',
+                        ),
+                        self::$test_file
+                );
+
+                delete_post_meta( $attachment_id, '_wp_attachment_metadata' );
+
+                $request  = new WP_REST_Request( 'GET', '/wp/v2/media/' . $attachment_id );
+                $response = rest_get_server()->dispatch( $request );
+                $data     = $response->get_data();
+
+                $this->assertInstanceOf( 'stdClass', $data['media_details'], 'media_details should be an empty object (stdClass) when metadata is missing.' );
+                $this->assertSame( '{}', wp_json_encode( $data['media_details'] ), 'media_details must JSON-encode as an empty object.' );
         }