Changeset 65122

Timestamp:

10/31/2026 04:41:03 PM (12 days ago)

Author:

lancewillett

Message:

Tests: Strengthen object-cache assertions.

Verify cache-group separation, missing entries, and bulk deletion. Cover empty and populated term relationship caches, including invalidation during deferred term counting.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/12642, ​https://github.com/WordPress/wordpress-develop/pull/13226

Props jorgelopezrepiso, sainathpoojary.
See #65693, #49799.

Location:

trunk/tests/phpunit/tests

Files:

• cache.php (modified) (4 diffs)
• term/getTheTerms.php (modified) (3 diffs)

trunk/tests/phpunit/tests/cache.php

@@ -459 +459 @@
                 wp_cache_set( 'foo1', 'bar', 'group1' );
                 wp_cache_set( 'foo2', 'bar', 'group1' );
-                wp_cache_set( 'foo1', 'bar', 'group2' );
-
-                $found = wp_cache_get_multiple( array( 'foo1', 'foo2', 'foo3' ), 'group1' );
+                wp_cache_set( 'foo3', 'bar', 'group2' );
+                wp_cache_set( 'foo1', 'bar2', 'group2' );
+
+                $found = wp_cache_get_multiple( array( 'foo1', 'foo2', 'foo3', 'foo4' ), 'group1' );
 
                 $expected = array(
@@ -467 +468 @@
                         'foo2' => 'bar',
                         'foo3' => false,
+                        'foo4' => false,
                 );
 
@@ -481 +483 @@
 
                 $found = wp_cache_delete_multiple(
-                        array( 'foo1', 'foo2', 'foo3' ),
+                        array( 'foo1', 'foo2', 'foo3', 'foo4' ),
                         'group1'
                 );
@@ -489 +491 @@
                         'foo2' => true,
                         'foo3' => false,
+                        'foo4' => false,
                 );
 
                 $this->assertSame( $expected, $found );
+
+                // Verify that foo1 and foo2 were actually deleted from group1.
+                $this->assertFalse( wp_cache_get( 'foo1', 'group1' ) );
+                $this->assertFalse( wp_cache_get( 'foo2', 'group1' ) );
+
+                // Verify that foo3 in group2 was untouched.
+                $this->assertSame( 'bar', wp_cache_get( 'foo3', 'group2' ) );
         }
 }

trunk/tests/phpunit/tests/term/getTheTerms.php

@@ -226 +226 @@
         /**
          * @ticket 40306
-         */
-        public function test_term_cache_should_be_invalidated_on_set_object_terms() {
+         * @ticket 49799
+         *
+         * @dataProvider data_term_cache_priming_functions
+         *
+         * @param string $priming_function Function used to prime the empty relationship cache.
+         */
+        public function test_term_cache_should_be_invalidated_on_set_object_terms( $priming_function ) {
                 register_taxonomy( 'wptests_tax', 'post' );
 
@@ -242 +247 @@
                 $post_id = self::factory()->post->create();
 
-                // Prime cache.
-                get_the_terms( $post_id, 'wptests_tax' );
-
-                wp_set_object_terms( $post_id, $term_id, 'wptests_tax' );
-
-                $terms = get_the_terms( $post_id, 'wptests_tax' );
-
-                // Re-activate term counting so this doesn't affect other tests.
-                wp_defer_term_counting( false );
-
-                $this->assertIsArray( $terms );
-                $this->assertSame( array( $term_id ), wp_list_pluck( $terms, 'term_id' ) );
+                try {
+                        // Prime cache with an empty array.
+                        if ( 'update_object_term_cache' === $priming_function ) {
+                                update_object_term_cache( array( $post_id ), array( 'post' ) );
+                        } else {
+                                get_the_terms( $post_id, 'wptests_tax' );
+                        }
+
+                        $cached = wp_cache_get( $post_id, 'wptests_tax_relationships' );
+                        $this->assertIsArray( $cached );
+                        $this->assertEmpty( $cached );
+
+                        wp_set_object_terms( $post_id, $term_id, 'wptests_tax' );
+
+                        $this->assertFalse( wp_cache_get( $post_id, 'wptests_tax_relationships' ) );
+
+                        $terms = get_the_terms( $post_id, 'wptests_tax' );
+
+                        $this->assertIsArray( $terms );
+                        $this->assertSame( array( $term_id ), wp_list_pluck( $terms, 'term_id' ) );
+                } finally {
+                        // Re-activate term counting so this doesn't affect other tests.
+                        wp_defer_term_counting( false );
+                }
+        }
+
+        /**
+         * Data provider for test_term_cache_should_be_invalidated_on_set_object_terms().
+         *
+         * @return array[]
+         */
+        public static function data_term_cache_priming_functions() {
+                return array(
+                        'get_the_terms'            => array( 'get_the_terms' ),
+                        'update_object_term_cache' => array( 'update_object_term_cache' ),
+                );
         }
 
@@ -290 +319 @@
                 $this->assertSame( array( $term_ids[1] ), wp_list_pluck( $terms, 'term_id' ) );
         }
+
+        /**
+         * Tests that get_the_terms() returns false for a post with no terms even when
+         * update_object_term_cache() has primed the cache with an empty array.
+         *
+         * @ticket 49799
+         */
+        public function test_get_the_terms_returns_false_for_post_with_no_terms_when_cache_primed() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $post_id = self::factory()->post->create();
+
+                // Prime cache with an empty array.
+                update_object_term_cache( array( $post_id ), array( 'post' ) );
+
+                $cached = wp_cache_get( $post_id, 'wptests_tax_relationships' );
+                $this->assertIsArray( $cached );
+                $this->assertEmpty( $cached );
+
+                $num_queries_before = get_num_queries();
+                $terms              = get_the_terms( $post_id, 'wptests_tax' );
+
+                $this->assertSame( 0, get_num_queries() - $num_queries_before );
+                $this->assertFalse( $terms );
+        }
+
+        /**
+         * Tests that get_the_terms() returns correct terms after update_object_term_cache()
+         * is called following term assignment.
+         *
+         * @ticket 49799
+         */
+        public function test_get_the_terms_returns_correct_terms_when_cache_primed_after_assignment() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $post_id = self::factory()->post->create();
+                $term_id = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+
+                wp_set_object_terms( $post_id, $term_id, 'wptests_tax' );
+
+                // Prime cache after assignment.
+                update_object_term_cache( array( $post_id ), array( 'post' ) );
+
+                $cached = wp_cache_get( $post_id, 'wptests_tax_relationships' );
+                $this->assertIsArray( $cached );
+                $this->assertNotEmpty( $cached );
+
+                $num_queries_before = get_num_queries();
+                $terms              = get_the_terms( $post_id, 'wptests_tax' );
+
+                $this->assertSame( 0, get_num_queries() - $num_queries_before );
+                $this->assertIsArray( $terms );
+                $this->assertCount( 1, $terms );
+                $this->assertSame( $term_id, (int) $terms[0]->term_id );
+        }
 }