Changeset 65335

Timestamp:

11/07/2026 11:18:43 PM (8 hours ago)

Author:

SergeyBiryukov

Message:

Tests: Align _test_filter_build_unique_id with _wp_filter_build_unique_id().

Includes:

• Returning null if the function ID for usage as array key could not be determined.
• Updating comments for accuracy.

Follow-up to r62408, r63334, r65314.

See #65819.

File:

• trunk/tests/phpunit/includes/functions.php (modified) (3 diffs)

trunk/tests/phpunit/includes/functions.php

@@ -82 +82 @@
  * @param int                   $priority  Unused. The order in which the functions
  *                                         associated with a particular action are executed.
- * @return string Unique function ID for usage as array key.
+ * @return string|null Unique function ID for usage as array key, or null if it couldn't be determined.
  */
 function _test_filter_build_unique_id( $hook_name, $callback, $priority ) {
@@ -90 +90 @@
 
         if ( is_object( $callback ) ) {
-                // Closures are currently implemented as objects.
+                /*
+                 * The prefix keeps the ID from being the decimal representation of an integer. PHP casts such a
+                 * string to int when it is used as an array key, which would change the type of the keys in
+                 * WP_Hook::$callbacks and break consumers that pass them to string functions.
+                 */
                 return 'spl_object_id:' . spl_object_id( $callback );
         }
 
-        $callback = (array) $callback;
+        if ( ! isset( $callback[1] ) || ! is_string( $callback[1] ) ) {
+                return null;
+        }
 
         if ( is_object( $callback[0] ) ) {
@@ -103 +109 @@
                 return $callback[0] . '::' . $callback[1];
         }
+
+        return null;
 }