Changeset 65409

Timestamp:

11/12/2026 03:30:19 AM (less than one hour ago)

Author:

lancewillett

Message:

Tests: Limit upload directory isolation to the Core test suite.

Preserve default upload paths for plugin and theme test suites. Only define and clean the dedicated uploads directory when WP_RUN_CORE_TESTS is enabled.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/15914

Props peterwilsoncc.
See #63532.

Location:

trunk/tests/phpunit/includes

Files:

• bootstrap.php (modified) (1 diff)
• functions.php (modified) (1 diff)

trunk/tests/phpunit/includes/bootstrap.php

@@ -251 +251 @@
 
 /*
+ * Isolate uploads in a dedicated directory when running the core test suite only,
+ * so that plugins and themes using the test suite keep the default uploads location.
+ *
  * Tests that cover the upload_path and upload_url_path options run in a separate process
  * with WP_TESTS_SKIP_UPLOADS_CONSTANT set, as UPLOADS overrides those options.
  */
-if ( ! defined( 'UPLOADS' ) && '1' !== getenv( 'WP_TESTS_SKIP_UPLOADS_CONSTANT' ) ) {
+if (
+        defined( 'WP_RUN_CORE_TESTS' ) && WP_RUN_CORE_TESTS
+        && ! defined( 'UPLOADS' )
+        && '1' !== getenv( 'WP_TESTS_SKIP_UPLOADS_CONSTANT' )
+) {
         define( 'UPLOADS', 'wp-content/test-suite-uploads' );
 

trunk/tests/phpunit/includes/functions.php

@@ -361 +361 @@
  */
 function _upload_get_url( $path = '', $scheme = 'http' ) {
-        return $scheme . '://' . WP_TESTS_DOMAIN . '/' . trailingslashit( UPLOADS ) . ltrim( $path, '/' );
+        $uploads = defined( 'UPLOADS' ) ? UPLOADS : 'wp-content/uploads';
+
+        return $scheme . '://' . WP_TESTS_DOMAIN . '/' . trailingslashit( $uploads ) . ltrim( $path, '/' );
 }