Changeset 6712

Timestamp:

02/02/2008 07:22:14 PM (17 years ago)

Author:

ryan

Message:

Don't hard code post type in edit forms. Props filosofo and DD32. fixes #4991

Location:

trunk

Files:

• wp-admin/edit-form-advanced.php (modified) (2 diffs)
• wp-admin/edit-page-form.php (modified) (2 diffs)
• wp-admin/includes/post.php (modified) (2 diffs)
• wp-admin/page-new.php (modified) (1 diff)
• wp-includes/default-filters.php (modified) (1 diff)

trunk/wp-admin/edit-form-advanced.php

@@ -47 +47 @@
 $saveasdraft = '<input name="save" type="submit" id="save" tabindex="3" value="' . attribute_escape( __('Save and Continue Editing') ) . '" />';
 
-if (empty($post->post_status)) $post->post_status = 'draft';
-
 ?>
 
@@ -55 +53 @@
 <input type="hidden" id="originalaction" name="originalaction" value="<?php echo $form_action ?>" />
 <input type="hidden" name="post_author" value="<?php echo attribute_escape( $post->post_author ); ?>" />
-<input type="hidden" id="post_type" name="post_type" value="post" />
+<input type="hidden" id="post_type" name="post_type" value="<?php echo $post->post_type ?>" />
 
 <?php echo $form_extra ?>

trunk/wp-admin/edit-page-form.php

@@ -28 +28 @@
 wp_nonce_field($nonce_action);
 
-if (isset($mode) && 'bookmarklet' == $mode) {
+if (isset($mode) && 'bookmarklet' == $mode)
     echo '<input type="hidden" name="mode" value="bookmarklet" />';
-}
 ?>
 <input type="hidden" id="user-id" name="user_ID" value="<?php echo $user_ID ?>" />
@@ -36 +35 @@
 <input type="hidden" id="originalaction" name="originalaction" value="<?php echo $form_action ?>" />
 <?php echo $form_extra ?>
-<input type="hidden" id="post_type" name="post_type" value="page" />
+<input type="hidden" id="post_type" name="post_type" value="<?php echo $post->post_type ?>" />
 
 <script type="text/javascript">

trunk/wp-admin/includes/post.php

@@ -144 +144 @@
 
     $post->post_status = 'draft';
+    $post->post_type = 'post';
     $post->comment_status = get_option( 'default_comment_status' );
     $post->ping_status = get_option( 'default_ping_status' );
@@ -156 +157 @@
 
     return $post;
+}
+
+function get_default_page_to_edit() {
+    $page = get_default_post_to_edit();
+    $page->post_type = 'page';
+    return $page;
 }
 

trunk/wp-admin/page-new.php

@@ -19 +19 @@
 if ( current_user_can('edit_pages') ) {
     $action = 'post';
-    $post = get_default_post_to_edit();
-    $post->post_type = 'page';
+    $post = get_default_page_to_edit();
 
     include('edit-page-form.php');

trunk/wp-includes/default-filters.php

@@ -61 +61 @@
 foreach ( $filters as $filter ) {
     add_filter($filter, 'sanitize_title');
+}
+
+// Keys
+$filters = array('pre_post_type');
+foreach ( $filters as $filter ) {
+    add_filter($filter, 'sanitize_user');
 }