Changeset 6794

Timestamp:

02/11/2008 11:19:09 PM (19 years ago)

Author:

ryan

Message:

Use full slug, not abbreviated slug, when editing. Props nbachiyski. fixes #5816

Location:

trunk/wp-admin

Files:

• includes/post.php (modified) (1 diff)
• js/slug.js (modified) (2 diffs)
• wp-admin.css (modified) (1 diff)

trunk/wp-admin/includes/post.php

@@ -556 +556 @@
                 return '';
         }
-        $title = __('You can edit this part of the permalink using the Edit button on the right');
+        $title = __('Click to edit this part of the permalink');
         if (strlen($post_name) > 30) {
-                $post_name = substr($post_name, 0, 14). '…' . substr($post_name, -14);
-        }
-        $post_name_html = '<span id="editable-post-name" title="'.$title.'">'.$post_name.'</span>';
+                $post_name_abridged = substr($post_name, 0, 14). '&hellip;' . substr($post_name, -14);
+        } else {
+                $post_name_abridged = $post_name;
+        }
+        $post_name_html = '<span id="editable-post-name" title="'.$title.'">'.$post_name_abridged.'</span><span id="editable-post-name-full">'.$post_name.'</span>';
         $display_link = str_replace('%postname%', $post_name_html, $permalink);
         return $display_link;

trunk/wp-admin/js/slug.js

@@ -4 +4 @@
         var revert_e = e.html();        
         var real_slug = jQuery('#post_name');
+        var revert_slug = real_slug.html();
         var b = jQuery('#edit-slug-buttons');
         var revert_b = b.html();
-        var old_slug = e.children('span').html();
+        var full = jQuery('#editable-post-name-full').html();
 
         b.html('<a href="" class="save">'+slugL10n.save+'</a> <a class="cancel" href="">'+slugL10n.cancel+'</a>');
@@ -26 +27 @@
                 e.html(revert_e);
                 b.html(revert_b);
-                real_slug.attr('value', revert_e);
+                real_slug.attr('value', revert_slug);
                 return false;
         });
-        for(i=0; i < revert_e.length; ++i) {
-                if ('%' == revert_e.charAt(i)) c++;
+        for(i=0; i < full.length; ++i) {
+                if ('%' == full.charAt(i)) c++;
         }
-        slug_value = (c > revert_e.length/4)? '' : revert_e;
+        slug_value = (c > full.length/4)? '' : full;
         e.html('<input type="text" id="new-post-slug" value="'+slug_value+'" />').children('input').keypress(function(e){
                 var key = e.charCode ? e.charCode : e.keyCode ? e.keyCode : 0;

trunk/wp-admin/wp-admin.css

@@ -1054 +1054 @@
 #edit-slug-box strong {color: #777;}
 #editable-post-name {background-color: #FFFBCC;}
+#editable-post-name-full {display: none;}
 #editable-post-name input {width: 16em;}
 #edit-slug-buttons a.save {