Changeset 7124

Timestamp:

03/01/2008 08:41:18 PM (18 years ago)

Author:

ryan

Message:

Fix passed by reference errors. Props DD32. fixes #6056

File:

• trunk/wp-admin/includes/media.php (modified) (3 diffs)

trunk/wp-admin/includes/media.php

@@ -33 +33 @@
         if ( isset($_GET['tab']) && array_key_exists($_GET['tab'], $tabs) )
             $current = $_GET['tab'];
-        else
-            $current = array_shift(array_keys($tabs));
+        else {
+            $keys = array_keys($tabs);
+            $current = array_shift($keys);
+        }
         foreach ( $tabs as $callback => $text ) {
             $class = '';
@@ -240 +242 @@
 
     if ( isset($_POST['send']) ) {
-        $send_id = (int) array_shift(array_keys($_POST['send']));
+        $keys = array_keys($_POST['send']);
+        $send_id = (int) array_shift($keys);
         $attachment = $_POST['attachments'][$send_id];
         $html = apply_filters('media_send_to_editor', get_the_attachment_link($send_id, 0, array(125,125), !empty($attachment['post_content'])), $send_id, $attachment);
@@ -630 +633 @@
 
     if ( isset($post_mime_types) ) {
-        $type = array_shift(array_keys(wp_match_mime_types(array_keys($post_mime_types), $post->post_mime_type)));
+        $keys = array_keys(wp_match_mime_types(array_keys($post_mime_types), $post->post_mime_type));
+        $type = array_shift($keys);
         $type = "<input type='hidden' id='type-of-$attachment_id' value='$type' />";
     }