Changeset 7472

Timestamp:

03/22/2008 09:14:49 AM (17 years ago)

Author:

westi

Message:

Improve the tabindex's on the Write>Post page. Need to do the others too.

Location:

trunk

Files:

• wp-admin/edit-form-advanced.php (modified) (6 diffs)
• wp-admin/includes/template.php (modified) (1 diff)
• wp-includes/category-template.php (modified) (2 diffs)

trunk/wp-admin/edit-form-advanced.php

@@ -85 +85 @@
 <p><strong><?php _e('Publish Status') ?></strong></p>
 <p>
-<select name='post_status'>
+<select name='post_status' tabindex='4'>
 <?php if ( current_user_can('publish_posts') ) : // Contributors only get "Unpublished" and "Pending Review" ?>
 <option<?php selected( $post->post_status, 'publish' ); selected( $post->post_status, 'private' );?> value='publish'><?php _e('Published') ?></option>
@@ -98 +98 @@
 
 <?php if ( current_user_can( 'publish_posts' ) ) : ?>
-<p><label for="post_status_private" class="selectit"><input id="post_status_private" name="post_status" type="checkbox" value="private" <?php checked($post->post_status, 'private'); ?> /> <?php _e('Keep this post private') ?></label></p>
+<p><label for="post_status_private" class="selectit"><input id="post_status_private" name="post_status" type="checkbox" value="private" <?php checked($post->post_status, 'private'); ?> tabindex="4" /> <?php _e('Keep this post private') ?></label></p>
 <?php endif; ?>
 <?php
@@ -121 +121 @@
 <?php if ( current_user_can( 'publish_posts' ) ) : // Contributors don't get to choose the date of publish ?>
 <p class="curtime"><?php printf($stamp, $date, $time); ?>
-&nbsp;<a href="#edit_timestamp" class="edit-timestamp"><?php _e('Edit') ?></a></p>
-
-<div id='timestampdiv'><?php touch_time(($action == 'edit')); ?></div>
+&nbsp;<a href="#edit_timestamp" class="edit-timestamp" tabindex='4'><?php _e('Edit') ?></a></p>
+
+<div id='timestampdiv'><?php touch_time(($action == 'edit'),1,4); ?></div>
 <?php endif; ?>
 
@@ -217 +217 @@
 
 <div id="category-adder" class="wp-hidden-children">
-    <h4><a id="category-add-toggle" href="#category-add"><?php _e( '+ Add New Category' ); ?></a></h4>
+    <h4><a id="category-add-toggle" href="#category-add" tabindex="3"><?php _e( '+ Add New Category' ); ?></a></h4>
     <p id="category-add" class="wp-hidden-child">
-        <input type="text" name="newcat" id="newcat" class="form-required form-input-tip" value="<?php _e( 'New category name' ); ?>" />
-        <?php wp_dropdown_categories( array( 'hide_empty' => 0, 'name' => 'newcat_parent', 'orderby' => 'name', 'hierarchical' => 1, 'show_option_none' => __('Parent category') ) ); ?>
-        <input type="button" id="category-add-sumbit" class="add:categorychecklist:categorydiv button" value="<?php _e( 'Add' ); ?>" />
+        <input type="text" name="newcat" id="newcat" class="form-required form-input-tip" value="<?php _e( 'New category name' ); ?>" tabindex="3" />
+        <?php wp_dropdown_categories( array( 'hide_empty' => 0, 'name' => 'newcat_parent', 'orderby' => 'name', 'hierarchical' => 1, 'show_option_none' => __('Parent category'), 'tab_index' => 3 ) ); ?>
+        <input type="button" id="category-add-sumbit" class="add:categorychecklist:categorydiv button" value="<?php _e( 'Add' ); ?>" tabindex="3" />
         <?php wp_nonce_field( 'add-category', '_ajax_nonce', false ); ?>
         <span id="category-ajax-response"></span>
@@ -228 +228 @@
 
 <ul id="category-tabs">
-    <li class="ui-tabs-selected"><a href="#categories-all"><?php _e( 'All Categories' ); ?></a></li>
-    <li class="wp-no-js-hidden"><a href="#categories-pop"><?php _e( 'Most Used' ); ?></a></li>
+    <li class="ui-tabs-selected"><a href="#categories-all" tabindex="3"><?php _e( 'All Categories' ); ?></a></li>
+    <li class="wp-no-js-hidden"><a href="#categories-pop" tabindex="3"><?php _e( 'Most Used' ); ?></a></li>
 </ul>
 
@@ -239 +239 @@
 
 <div id="categories-pop" class="ui-tabs-panel" style="display: none;">
-    <ul id="categorychecklist-pop" class="categorychecklist form-no-clear">
+    <ul id="categorychecklist-pop" class="categorychecklist form-no-clear" >
         <?php wp_popular_terms_checklist('category'); ?>
     </ul>

trunk/wp-admin/includes/template.php

@@ -193 +193 @@
         ?>
 
-        <li id="<?php echo $id; ?>">
+        <li id="<?php echo $id; ?>" >
             <label class="selectit" for="in-<?php echo $id; ?>">
-                <input id="in-<?php echo $id; ?>" type="checkbox" value="<?php echo (int) $category->term_id; ?>" />
+            <input id="in-<?php echo $id; ?>" type="checkbox" value="<?php echo (int) $category->term_id; ?>" />
                 <?php echo wp_specialchars( apply_filters( 'the_category', $category->name ) ); ?>
             </label>

trunk/wp-includes/category-template.php

@@ -217 +217 @@
         'selected' => 0, 'hierarchical' => 0,
         'name' => 'cat', 'class' => 'postform',
-        'depth' => 0
+        'depth' => 0, 'tab_index' => 0
     );
 
@@ -226 +226 @@
     extract( $r );
 
+    $tab_index_attribute = '';
+    if ( (int) $tab_index > 0 )
+        $tab_index_attribute = " tabindex=\"$tab_index\"";
+
     $categories = get_categories($r);
 
     $output = '';
     if ( ! empty($categories) ) {
-        $output = "<select name='$name' id='$name' class='$class'>\n";
+        $output = "<select name='$name' id='$name' class='$class' $tab_index_attribute>\n";
 
         if ( $show_option_all ) {