Changeset 7745

Timestamp:

04/18/2008 10:23:02 PM (17 years ago)

Author:

ryan

Message:

Shift-click to select a range of checkboxes. Props mdawaffe. fixes #6541 for trunk

Location:

trunk

Files:

• wp-admin/categories.php (modified) (1 diff)
• wp-admin/edit-comments.php (modified) (1 diff)
• wp-admin/edit-link-categories.php (modified) (1 diff)
• wp-admin/edit-tags.php (modified) (1 diff)
• wp-admin/includes/template.php (modified) (3 diffs)
• wp-admin/js/forms.js (modified) (1 diff)
• wp-admin/link-manager.php (modified) (1 diff)
• wp-admin/users.php (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/wp-admin/categories.php

@@ -148 +148 @@
     <thead>
     <tr>
-        <th scope="col" class="check-column"><input type="checkbox" onclick="checkAll(document.getElementById('posts-filter'));" /></th>
+        <th scope="col" class="check-column"><input type="checkbox" /></th>
         <th scope="col"><?php _e('Name') ?></th>
         <th scope="col"><?php _e('Description') ?></th>

trunk/wp-admin/edit-comments.php

@@ -186 +186 @@
 <thead>
   <tr>
-    <th scope="col" class="check-column"><input type="checkbox" onclick="checkAll(document.getElementById('comments-form'));" /></th>
+    <th scope="col" class="check-column"><input type="checkbox" /></th>
     <th scope="col"><?php _e('Comment') ?></th>
     <th scope="col"><?php _e('Date') ?></th>

trunk/wp-admin/edit-link-categories.php

@@ -102 +102 @@
     <thead>
     <tr>
-        <th scope="col" class="check-column"><input type="checkbox" onclick="checkAll(document.getElementById('posts-filter'));" /></th>
+        <th scope="col" class="check-column"><input type="checkbox" /></th>
         <th scope="col"><?php _e('Name') ?></th>
         <th scope="col"><?php _e('Description') ?></th>

trunk/wp-admin/edit-tags.php

@@ -173 +173 @@
     <thead>
     <tr>
-    <th scope="col" class="check-column"><input type="checkbox" onclick="checkAll(document.getElementById('posts-filter'));" /></th>
+    <th scope="col" class="check-column"><input type="checkbox" /></th>
         <th scope="col"><?php _e('Name') ?></th>
         <th scope="col" class="num" style="width: 90px"><?php _e('Posts') ?></th>

trunk/wp-admin/includes/template.php

@@ -280 +280 @@
 function wp_manage_posts_columns() {
     $posts_columns = array();
-    $posts_columns['cb'] = '<input type="checkbox" onclick="checkAll(document.getElementById(\'posts-filter\'));" />';
+    $posts_columns['cb'] = '<input type="checkbox" />';
     if ( 'draft' === $_GET['post_status'] )
         $posts_columns['modified'] = __('Modified');
@@ -302 +302 @@
 function wp_manage_media_columns() {
     $posts_columns = array();
-    $posts_columns['cb'] = '<input type="checkbox" onclick="checkAll(document.getElementById(\'posts-filter\'));" />';
+    $posts_columns['cb'] = '<input type="checkbox" />';
     $posts_columns['icon'] = '';
     $posts_columns['media'] = _c('Media|media column header');
@@ -317 +317 @@
 function wp_manage_pages_columns() {
     $posts_columns = array();
-    $posts_columns['cb'] = '<input type="checkbox" onclick="checkAll(document.getElementById(\'posts-filter\'));" />';
+    $posts_columns['cb'] = '<input type="checkbox" />';
     if ( 'draft' === $_GET['post_status'] )
         $posts_columns['modified'] = __('Modified');

trunk/wp-admin/js/forms.js

@@ -1 @@
-function checkAll(form) {
-    for (i = 0, n = form.elements.length; i < n; i++) {
-        if(form.elements[i].type == "checkbox" && !(form.elements[i].getAttribute('onclick',2))) {
-            if(form.elements[i].checked == true)
-                form.elements[i].checked = false;
-            else
-                form.elements[i].checked = true;
-        }
-    }
+function checkAll(jQ) { // use attr( checked, fn )
+    jQuery(jQ).find( 'tbody :checkbox' ).attr( 'checked', function() {
+        return jQuery(this).attr( 'checked' ) ? '' : 'checked';
+    } );
 }
 
-function getNumChecked(form) {
-    var num = 0;
-    for (i = 0, n = form.elements.length; i < n; i++) {
-        if (form.elements[i].type == "checkbox") {
-            if (form.elements[i].checked == true)
-                num++;
+jQuery( function($) {
+    var lastClicked = false;
+    $( 'tbody :checkbox' ).click( function(e) {
+        if ( 'undefined' == e.shiftKey ) { return true; }
+        if ( e.shiftKey ) {
+            if ( !lastClicked ) { return true; }
+            var checks = $( lastClicked ).parents( 'form:first' ).find( ':checkbox' );
+            var first = checks.index( lastClicked );
+            var last = checks.index( this );
+            if ( 0 < first && 0 < last && first != last ) {
+                checks.slice( first, last ).attr( 'checked', $( this ).is( ':checked' ) ? 'checked' : '' );
+            }
         }
-    }
-    return num;
-}
-
-function checkAllUsers(role) {
- var checkboxs = document.getElementsByTagName('input');
- for(var i = 0, inp; inp = checkboxs[i]; i++)
-    if(inp.type.toLowerCase() == 'checkbox' && inp.className == role)
-        if(inp.checked == false)
-            inp.checked = true;
-        else
-            inp.checked = false;
-}
+        lastClicked = this;
+        return true;
+    } );
+    $( 'thead :checkbox' ).click( function() {
+        checkAll( $(this).parents( 'form:first' ) );
+    } );
+} );

trunk/wp-admin/link-manager.php

@@ -142 +142 @@
     <thead>
     <tr>
-    <th scope="col" class="check-column"><input type="checkbox" onclick="checkAll(document.getElementById('posts-filter'));" /></th>
+    <th scope="col" class="check-column"><input type="checkbox" /></th>
 <?php foreach($link_columns as $column_display_name) {
     echo $column_display_name;

trunk/wp-admin/users.php

@@ -331 +331 @@
 <thead>
 <tr class="thead">
-    <th scope="col" class="check-column"><input type="checkbox" onclick="checkAll(document.getElementById('posts-filter'));" /> </th>
+    <th scope="col" class="check-column"><input type="checkbox" /></th>
     <th><?php _e('Username') ?></th>
     <th><?php _e('Name') ?></th>

trunk/wp-includes/script-loader.php

@@ -132 +132 @@
             ) );
             $this->add( 'admin-users', '/wp-admin/js/users.js', array('wp-lists'), '20070823' );
-            $this->add( 'admin-forms', '/wp-admin/js/forms.js', false, '20080317' );
+            $this->add( 'admin-forms', '/wp-admin/js/forms.js', false, '20080401');
             $this->add( 'xfn', '/wp-admin/js/xfn.js', false, '3517' );
             $this->add( 'upload', '/wp-admin/js/upload.js', array('jquery'), '20070518' );