Changeset 7900

Timestamp:

05/05/2008 11:19:27 PM (18 years ago)

Author:

ryan

Message:

wp_insert_post() -- Validate page template, check return of insert and update queries, add option to return WP_Error. fixes #6227 see #6098

File:

• trunk/wp-includes/post.php (modified) (6 diffs)

trunk/wp-includes/post.php

@@ -1110 +1110 @@
  * @return int post ID or 0 on error
  */
-function wp_insert_post($postarr = array()) {
+function wp_insert_post($postarr = array(), $wp_error = false) {
         global $wpdb, $wp_rewrite, $user_ID;
 
@@ -1133 +1133 @@
         }
 
-        if ( ('' == $post_content) && ('' == $post_title) && ('' == $post_excerpt) )
-                return 0;
+        if ( ('' == $post_content) && ('' == $post_title) && ('' == $post_excerpt) ) {
+                if ( $wp_error )
+                        return new WP_Error('empty_content', __('Content, title, and excerpt are empty.'));
+                else
+                        return 0;
+        }
 
         // Make sure we set a valid category
@@ -1245 +1249 @@
         if ($update) {
                 do_action( 'pre_post_update', $post_ID );
-                $wpdb->update( $wpdb->posts, $data, $where );
+                if ( false === $wpdb->update( $wpdb->posts, $data, $where ) ) {
+                        if ( $wp_error )
+                                return new WP_Error('db_update_error', __('Could not update post in the database'), $wpdb->last_error);
+                        else
+                                return 0;
+                }
         } else {
                 $data['post_mime_type'] = stripslashes( $post_mime_type ); // This isn't in the update
-                $wpdb->insert( $wpdb->posts, $data );
+                if ( false === $wpdb->insert( $wpdb->posts, $data ) ) {
+                        if ( $wp_error )
+                                return new WP_Error('db_insert_error', __('Could not insert post into the database'), $wpdb->last_error);
+                        else
+                                return 0;       
+                }
                 $post_ID = (int) $wpdb->insert_id;
 
@@ -1265 +1279 @@
         $current_guid = get_post_field( 'guid', $post_ID );
 
-        if ( 'page' == $post_type ) {
+        if ( 'page' == $post_type )
                 clean_page_cache($post_ID);
-        } else {
+        else
                 clean_post_cache($post_ID);
-        }
 
         // Set GUID
@@ -1276 +1289 @@
 
         $post = get_post($post_ID);
-        if ( !empty($page_template) )
+
+        if ( !empty($page_template) && 'page' == $post_type ) {
                 $post->page_template = $page_template;
+                $page_templates = get_page_templates();
+                if ( ! in_array($page_template, $page_templates) ) {
+                        if ( $wp_error )
+                                return new WP_Error('invalid_page_template', __('The page template is invalid.'));
+                        else
+                                return 0;
+                }
+                if ( ! update_post_meta($post_ID, '_wp_page_template',  $page_template) )
+                        add_post_meta($post_ID, '_wp_page_template',  $page_template, true);
+        }
 
         wp_transition_post_status($post_status, $previous_status, $post);
@@ -2898 +2922 @@
 function _save_post_hook($post_id, $post) {
         if ( $post->post_type == 'page' ) {
-                if ( !empty($post->page_template) )
-                        if ( ! update_post_meta($post_id, '_wp_page_template',  $post->page_template))
-                                add_post_meta($post_id, '_wp_page_template',  $post->page_template, true);
-
                 clean_page_cache($post_id);
                 global $wp_rewrite;