Changeset 7985

Timestamp:

05/22/2008 04:33:06 PM (17 years ago)

Author:

ryan

Message:

Remove unnecessary checks for the existence of post meta data. Props filosofo. fixes #7018

File:

• trunk/wp-includes/post.php (modified) (3 diffs)

trunk/wp-includes/post.php

@@ -45 +45 @@
         return false;
 
-    $old_file = get_attached_file( $attachment_id, true );
-
     $file = apply_filters( 'update_attached_file', $file, $attachment_id );
 
-    if ( $old_file )
-        return update_post_meta( $attachment_id, '_wp_attached_file', $file, $old_file );
-    else
-        return add_post_meta( $attachment_id, '_wp_attached_file', $file );
+    return update_post_meta( $attachment_id, '_wp_attached_file', $file );
 }
 
@@ -1305 +1300 @@
                 return 0;
         }
-        if ( ! update_post_meta($post_ID, '_wp_page_template',  $page_template) )
-            add_post_meta($post_ID, '_wp_page_template',  $page_template, true);
+        update_post_meta($post_ID, '_wp_page_template',  $page_template);
     }
 
@@ -2243 +2237 @@
         return false;
 
-    $old_data = wp_get_attachment_metadata( $post->ID, true );
-
     $data = apply_filters( 'wp_update_attachment_metadata', $data, $post->ID );
 
-    if ( $old_data )
-        return update_post_meta( $post->ID, '_wp_attachment_metadata', $data, $old_data );
-    else
-        return add_post_meta( $post->ID, '_wp_attachment_metadata', $data );
+    return update_post_meta( $post->ID, '_wp_attachment_metadata', $data);
 }