Changeset 8102

Timestamp:

06/16/2008 08:44:30 PM (13 years ago)

Author:

ryan

Message:

Don't unpublish pages when a user who can edit publised pages but not publish new pages edits a page. Props jeremyclarke. fixes #6943 #7070 for 2.5

Location:

branches/2.5/wp-admin

Files:

• edit-page-form.php (modified) (2 diffs)
• includes/post.php (modified) (1 diff)

branches/2.5/wp-admin/edit-page-form.php

@@ -69 +69 @@
 
 <div class="inside">
-
 <p><strong><?php _e('Publish Status') ?></strong></p>
 <p>
 <select name='post_status' tabindex='4'>
-<?php if ( current_user_can('publish_pages') ) : ?>
+<?php // Show publish in dropdown if user can publish or if they can re-publish this page ('edit_published_pages')
+// 'publish' option will be selected for published AND private posts (checkbox overrides dropdown)
+if ( current_user_can('publish_pages') OR ( $post->post_status == 'publish' AND current_user_can('edit_page', $post->ID) ) ) : 
+?>
 <option<?php selected( $post->post_status, 'publish' ); selected( $post->post_status, 'private' );?> value='publish'><?php _e('Published') ?></option>
-<?php else: ?>
-<option<?php selected( $post->post_status, 'private' ); ?> value='private'><?php _e('Published') ?></option>
 <?php endif; ?>
 <?php if ( 'future' == $post->post_status ) : ?>
@@ -85 +85 @@
 </select>
 </p>
-
+<?php if ( current_user_can( 'publish_posts' ) ) : ?> 
 <p><label for="post_status_private" class="selectit"><input id="post_status_private" name="post_status" type="checkbox" value="private" <?php checked($post->post_status, 'private'); ?> tabindex='4' /> <?php _e('Keep this page private') ?></label></p>
+<?php endif; ?>
+
 <?php
 if ($post_ID) {

branches/2.5/wp-admin/includes/post.php

@@ -63 +63 @@
     if ( 'page' == $_POST['post_type'] ) {
         if ('publish' == $_POST['post_status'] && !current_user_can( 'publish_pages' ))
-            $_POST['post_status'] = 'pending';
+            if ( $previous_status != 'publish' OR !current_user_can( 'edit_published_pages') )
+                $_POST['post_status'] = 'pending';
     } else {
         if ('publish' == $_POST['post_status'] && !current_user_can( 'publish_posts' ))