Changeset 8385

Timestamp:

07/21/2008 01:15:49 AM (17 years ago)

Author:

azaozz

Message:

Take first attribute and ignore later duplicate attributes. Fixes #6602 for 2.6.1. Props schiller.

File:

• branches/2.6/wp-includes/kses.php (modified) (6 diffs)

branches/2.6/wp-includes/kses.php

@@ -538 +538 @@
  * or apostrophes around them, to make it easier to produce HTML code that will
  * conform to W3C's HTML specification. It will also remove bad URL protocols
- * from attribute values.
+ * from attribute values.  It also reduces duplicate attributes by using the
+ * attribute defined first (foo='bar' foo='baz' will result in foo='bar').
  *
  * @since 1.0.0
@@ -581 +582 @@
                     $working = 1;
                     $mode = 0;
-                    $attrarr[] = array ('name' => $attrname, 'value' => '', 'whole' => $attrname, 'vless' => 'y');
+                    if(FALSE === array_key_exists($attrname, $attrarr)) {
+                        $attrarr[$attrname] = array ('name' => $attrname, 'value' => '', 'whole' => $attrname, 'vless' => 'y');
+                    }
                     $attr = preg_replace('/^\s+/', '', $attr);
                 }
@@ -594 +597 @@
                     $thisval = wp_kses_bad_protocol($match[1], $allowed_protocols);
 
-                    $attrarr[] = array ('name' => $attrname, 'value' => $thisval, 'whole' => "$attrname=\"$thisval\"", 'vless' => 'n');
+                    if(FALSE === array_key_exists($attrname, $attrarr)) {
+                        $attrarr[$attrname] = array ('name' => $attrname, 'value' => $thisval, 'whole' => "$attrname=\"$thisval\"", 'vless' => 'n');
+                    }
                     $working = 1;
                     $mode = 0;
@@ -606 +611 @@
                     $thisval = wp_kses_bad_protocol($match[1], $allowed_protocols);
 
-                    $attrarr[] = array ('name' => $attrname, 'value' => $thisval, 'whole' => "$attrname='$thisval'", 'vless' => 'n');
+                    if(FALSE === array_key_exists($attrname, $attrarr)) {
+                        $attrarr[$attrname] = array ('name' => $attrname, 'value' => $thisval, 'whole' => "$attrname='$thisval'", 'vless' => 'n');
+                    }
                     $working = 1;
                     $mode = 0;
@@ -618 +625 @@
                     $thisval = wp_kses_bad_protocol($match[1], $allowed_protocols);
 
-                    $attrarr[] = array ('name' => $attrname, 'value' => $thisval, 'whole' => "$attrname=\"$thisval\"", 'vless' => 'n');
+                    if(FALSE === array_key_exists($attrname, $attrarr)) {
+                        $attrarr[$attrname] = array ('name' => $attrname, 'value' => $thisval, 'whole' => "$attrname=\"$thisval\"", 'vless' => 'n');
+                    }
                     # We add quotes to conform to W3C's HTML spec.
                     $working = 1;
@@ -635 +644 @@
     } # while
 
-    if ($mode == 1)
+    if ($mode == 1 && FALSE === array_key_exists($attrname, $attrarr))
         # special case, for when the attribute list ends with a valueless
         # attribute like "selected"
-        $attrarr[] = array ('name' => $attrname, 'value' => '', 'whole' => $attrname, 'vless' => 'y');
+        $attrarr[$attrname] = array ('name' => $attrname, 'value' => '', 'whole' => $attrname, 'vless' => 'y');
 
     return $attrarr;