Changeset 891 in tests

Timestamp:

07/09/2012 02:12:58 PM (13 years ago)

Author:

nacin

Message:

Request all open tickets from a Trac install at once.

This prevents repeated HTTP requests for individual tickets and
allows us to keep knownWPBug (or @ticket - see #102) in place for
tickets already closed, without any real performance penalty.
This is good for tracking and also in case a bug is reopened.

This shaved 30 seconds off the test suite run time for me.

File:

• trunk/includes/trac.php (modified) (2 diffs)

trunk/includes/trac.php

@@ -3 +3 @@
 class TracTickets {
     /**
-     * Whenever a track ticket is checked to see if it's closed or not
-     * the results are stored here
+     * When open tickets for a Trac install is requested, the results are stored here.
+     *
      * @var array
      */
@@ -14 +14 @@
      * @return bool|null true if the ticket is resolved, false if not resolved, null on error
      */
-    static function isTracTicketClosed($trac_url, $ticket_id) {
-        $trac_url = rtrim($trac_url, '/');
-        $url = "$trac_url/ticket/$ticket_id?format=tab";
-        if ( array_key_exists( $url, self::$trac_ticket_cache ) ) {
-            return self::$trac_ticket_cache[$url];
+    public static function isTracTicketClosed( $trac_url, $ticket_id ) {
+        if ( ! isset( self::$trac_ticket_cache[ $trac_url ] ) ) {
+            $tickets = file_get_contents( $trac_url . '/query?status=%21closed&format=csv&col=id' );
+            $tickets = substr( $tickets, 2 ); // remove 'id'
+            $tickets = trim( $tickets );
+            $tickets = explode( "\r\n", $tickets );
+            self::$trac_ticket_cache[ $trac_url ] = $tickets;
         }
-        $ticket_tsv = file_get_contents($url);
-        if (false === $ticket_tsv) {
-            self::$trac_ticket_cache[$url] = null;
-            return self::$trac_ticket_cache[$url];
-        }
-        $lines = explode("\n", $ticket_tsv, 2);
-        if (!is_array($lines) || count($lines) < 2) {
-            self::$trac_ticket_cache[$url] = null;
-            return self::$trac_ticket_cache[$url];
-        }
-        $titles = str_getcsv( $lines[0], "\t" );
-        $status_idx = array_search('status', $titles);
-        if (false === $status_idx) {
-            self::$trac_ticket_cache[$url] = null;
-            return self::$trac_ticket_cache[$url];
-        }
-        $tabs = str_getcsv( $lines[1], "\t" );
-        self::$trac_ticket_cache[$url] = ( 'closed' === $tabs[$status_idx] );
-        return self::$trac_ticket_cache[$url];
+
+        return ! in_array( $ticket_id, self::$trac_ticket_cache[ $trac_url ] );
     }
 }